Add events API - #276
Merged
Merged
Conversation
jessegeens
force-pushed
the
feat/notifications
branch
from
July 14, 2026 09:05
28a73bb to
008fcea
Compare
jessegeens
marked this pull request as ready for review
July 16, 2026 08:19
jessegeens
marked this pull request as draft
July 16, 2026 14:29
jessegeens
force-pushed
the
feat/notifications
branch
3 times, most recently
from
July 20, 2026 13:54
02f271a to
8d4f8a5
Compare
jessegeens
force-pushed
the
feat/notifications
branch
from
July 20, 2026 15:01
8d4f8a5 to
fc465f1
Compare
jessegeens
marked this pull request as ready for review
July 20, 2026 15:01
glpatcern
approved these changes
Jul 23, 2026
glpatcern
left a comment
Member
There was a problem hiding this comment.
I think we can go ahead with this non-breaking change (let alone the need to define stubs if not implemented).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
We would like to propose an event-based notifications API in the CS3APIs.
We are reworking our implementation of notifications in Reva and we think this is a nice way to handle it. The idea is that there are certain "events" in reva that a user might want to be notified of (e.g. a share is created, file is uploaded in a folder, etc). There are many ways these can be handled (email, push notification, etc.). Users might also have preferences for how often they want to be contacted, and for certain event types you also want to accumulate some events (e.g. a user uploading 100 files).
We decided to make it more generic, so that events can also be used to trigger other actions. With this API, it is completely up to the handler to handle all of this; all you set is an
event_typeand some data and the implementation then chooses what to do with it (we will use a system where you can define rules for event types in the config).What do you think (@aduffeck @micbar @butonic)?