labs/lab-04: Fix support/grumpy_jumps.asm#159
Open
onefieryfern wants to merge 1 commit intocs-pub-ro:mainfrom
Open
labs/lab-04: Fix support/grumpy_jumps.asm#159onefieryfern wants to merge 1 commit intocs-pub-ro:mainfrom
onefieryfern wants to merge 1 commit intocs-pub-ro:mainfrom
Conversation
Exercise was intended to fall through from the `good` label to the `bad` label before the student fixes it. This commit fixes the issue by removing the early return from the `good` label Signed-off-by: Andrei Florea <andreifl@posteo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes
Exercise was intended to fall through from the
goodlabel to thebadlabel before the student fixes it. This commit fixes the issue by removing the early return from thegoodlabelThis is seen in the
grumpy_jumpsREADME.md