Support named parameters in the build script#192
Open
jdevera wants to merge 5 commits intocriteo:mainfrom
Open
Support named parameters in the build script#192jdevera wants to merge 5 commits intocriteo:mainfrom
jdevera wants to merge 5 commits intocriteo:mainfrom
Conversation
…y support Replace the positional-only build script with a flag-based CLI: - Named flags: -v/--version, -n/--name, -l/--long-name, -o/--output - New -b/--build-number flag for stable CI build numbers (github.run_number) - Legacy positional args (VERSION NAME LONG_NAME) still work for muscle memory - Debug mode (-d), help (-h), and input validation - Update CI workflow to use build.sh with -b for stable build numbers - Update docs (README, introduction, build-from-source) with new usage
Contributor
Author
|
I've merge the recent changes, fixed the CI issue, and integrated the new --resign flag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I wanted to be able to run the build script and just modify some of the parameters without having to follow the exact order of the positional arguments. I ended up keeping my own script and thought this could be a good addition to upstream.
Changes:
-v/--version,-n/--name,-l/--long-name,-o/--output,-b/--build-number-b/--build-numberflag so CI can passgithub.run_numberfor stable build numbers instead of timestamps--resignmacOS code-signing feature as-r/--resign./build.sh VERSION NAME LONG_NAME [--resign]) is preservedbuild.shwith the new flagsI ran these tests:
-v,-n,-l,-o,-b,-r,-d,-h)--resignas 4th positional argmyapp version 1.2.3, build 99)--resigntriggerscodesignon macOS (replaces linker signature with ad-hoc codesign)