perf: eliminate ArrayBuffer copies at the JSI boundary#49
Open
GrzywN wants to merge 1 commit intocraftzdog:masterfrom
Open
perf: eliminate ArrayBuffer copies at the JSI boundary#49GrzywN wants to merge 1 commit intocraftzdog:masterfrom
GrzywN wants to merge 1 commit intocraftzdog:masterfrom
Conversation
Encoding (fromByteArray): call the raw-pointer overload of base64_encode directly with buf.data(runtime)/buf.size(runtime) instead of copying the ArrayBuffer into a temporary std::string first. Decoding (toByteArray): introduce a minimal DecodedBuffer (jsi::MutableBuffer subclass) that takes ownership of the decoded std::string via move and returns it as jsi::ArrayBuffer(runtime, make_shared<DecodedBuffer>(std::move(...))). The JSI runtime holds the buffer alive via shared_ptr — no second allocation, no memcpy. Also tighten the argument guard in base64ToArrayBuffer from 'count > 0 && !isString' to 'count == 0 || !isString' to prevent a potential out-of-bounds access when called with zero arguments.
Author
|
Opening new issues is broken (404 Not Found) - I created a PR with this change instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding (fromByteArray): call the raw-pointer overload of base64_encode directly with buf.data(runtime)/buf.size(runtime) instead of copying the ArrayBuffer into a temporary std::string first.
Decoding (toByteArray): introduce a minimal DecodedBuffer (jsi::MutableBuffer subclass) that takes ownership of the decoded std::string via move and returns it as jsi::ArrayBuffer(runtime, make_shared(std::move(...))). The JSI runtime holds the buffer alive via shared_ptr — no second allocation, no memcpy.
Also tighten the argument guard in base64ToArrayBuffer from 'count > 0 && !isString' to 'count == 0 || !isString' to prevent a potential out-of-bounds access when called with zero arguments.
Screenshots