Conversation
- allow parallel runners by default, useful for working on multiple parts of a repo simultaneously
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves a structtag lint violation flagged by newer staticcheck and updates golangci-lint configuration to permit running multiple linters concurrently against the same repo checkout.
Changes:
- Fix invalid JSON struct tag on
StartupConfig.DeprecatedConfigto satisfystructtagchecks. - Enable
run.allow-parallel-runnersin both standard and strict golangci-lint configurations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
rest/config_startup.go |
Fixes an invalid json struct tag that newer linters reject. |
.golangci.yml |
Enables parallel runners to reduce friction when running lint concurrently. |
.golangci-strict.yml |
Enables parallel runners for the strict lint configuration used in CI. |
Collaborator
Author
|
This ends up being a behavior change, previously the structtag was literally From https://pkg.go.dev/encoding/json
I highly doubt anyone knew about this and was relying on this behavior. |
bbrks
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue with the structtag was found with newer versions of staticcheck on the .golangci-strict.yml