bump to v0.3.0-alpha snapshot (y_nab update)#467
Open
bl-young wants to merge 1 commit into
Open
Conversation
MoLi7
approved these changes
Jun 16, 2026
MoLi7
left a comment
Member
There was a problem hiding this comment.
so we ARE including this in v0.3? acknowledging this wouldn't change EF values
Member
Author
|
I think we have to or we need to revert #458 for now |
Member
Author
|
Why don't we hold and discuss tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc:
Closes:
What changed? Why?
Snapshot regeneration for #458 (
feat(eeio): derive y_nab from Adom and scaled_q, merge4d67c8f). Marked asv0.3.0-alphain anticipation of v0.3 release coming soon.y_nab_USAis backcomputed fromderive_cornerstone_Aq_scaled()viabackcompute_y_from_A_and_q(Adom, scaled_q), enforcing IO row balance and domestic Leontief consistency with snapshottedscaled_qandAdom. The prior path disaggregated BEA Y/trade and clipped negatives; that path was inconsistent with the A/qpipeline.Snapshot delta vs v0.2 (
7372464…):Adom_USA,Aimp_USA,scaled_q_USAB_USA_non_finetunedytot_USA,exports_USA,ydom_USA,yimp_USAy_nab_USAy_nab_USAsummary (live @4d67c8fvs v0.2 snapshot):sum(y)−0.266% (−7.60×10¹⁰ on ~2.85×10¹³ total)y_nab(was 0 under clipping); 5 sectors that were exactly 0 now nonzeroS00402(0 → −3.79×10¹⁰),5241XX,230302,541700Domestic Leontief identity
q ≈ L_dom @ y_nabpasses at 1% rtol with the newy_nab(0 failing sectors locally).test_compare_output_and_L_y[Commodity-True-cornerstone]passes locally; re-run integration after bump if CI still flakes on zero-qsectors.GCS:
gs://cornerstone-default/snapshots/4d67c8f0f5721a30ce03f4d3eef85a82e7199032/Generated via generate_snapshots workflow run 27585443941 on
main@4d67c8f.Mechanical file changes:
Testing