Skip to content

bump to v0.3.0-alpha snapshot (y_nab update)#467

Open
bl-young wants to merge 1 commit into
mainfrom
v0_3_0_alpha_snapshot
Open

bump to v0.3.0-alpha snapshot (y_nab update)#467
bl-young wants to merge 1 commit into
mainfrom
v0_3_0_alpha_snapshot

Conversation

@bl-young

Copy link
Copy Markdown
Member

cc:
Closes:

What changed? Why?

Snapshot regeneration for #458 (feat(eeio): derive y_nab from Adom and scaled_q, merge 4d67c8f). Marked as v0.3.0-alpha in anticipation of v0.3 release coming soon.

y_nab_USA is backcomputed from derive_cornerstone_Aq_scaled() via backcompute_y_from_A_and_q(Adom, scaled_q), enforcing IO row balance and domestic Leontief consistency with snapshotted scaled_q and Adom. The prior path disaggregated BEA Y/trade and clipped negatives; that path was inconsistent with the A/q pipeline.

Snapshot delta vs v0.2 (7372464…):

Artifact Changed?
Adom_USA, Aimp_USA, scaled_q_USA No (machine precision)
B_USA_non_finetuned No
ytot_USA, exports_USA, ydom_USA, yimp_USA No
y_nab_USA Yes — 393/405 sectors outside snapshot tolerance

y_nab_USA summary (live @ 4d67c8f vs v0.2 snapshot):

  • sum(y) −0.266% (−7.60×10¹⁰ on ~2.85×10¹³ total)
  • Median |sector % diff| among sectors with nonzero old values: ~5.5%
  • 24 sectors now have negative y_nab (was 0 under clipping); 5 sectors that were exactly 0 now nonzero
  • Largest |diff|: S00402 (0 → −3.79×10¹⁰), 5241XX, 230302, 541700

Domestic Leontief identity q ≈ L_dom @ y_nab passes at 1% rtol with the new y_nab (0 failing sectors locally). test_compare_output_and_L_y[Commodity-True-cornerstone] passes locally; re-run integration after bump if CI still flakes on zero-q sectors.

GCS: gs://cornerstone-default/snapshots/4d67c8f0f5721a30ce03f4d3eef85a82e7199032/

Generated via generate_snapshots workflow run 27585443941 on main @ 4d67c8f.

Mechanical file changes:

bedrock/utils/snapshots/.SNAPSHOT_KEY          → 4d67c8f0f5721a30ce03f4d3eef85a82e7199032
bedrock/utils/snapshots/releases.py            → add v0_3_0_alpha entry
bedrock/utils/config/usa_config.py             → extend snapshot_version_or_git_sha Literal

Testing

uv run pytest bedrock/transform/__tests__/test_usa.py -m eeio_integration -v
uv run pytest "bedrock/utils/validation/__tests__/test_eeio_diagnostics.py::test_compare_output_and_L_y[Commodity-True-cornerstone]" -m eeio_integration -v

@bl-young bl-young changed the title bump to v0.3.0-alpha snapshot (ynab calculation) bump to v0.3.0-alpha snapshot (y_nab update) Jun 16, 2026
@bl-young bl-young requested review from MoLi7 and WesIngwersen and removed request for WesIngwersen June 16, 2026 00:38

@MoLi7 MoLi7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we ARE including this in v0.3? acknowledging this wouldn't change EF values

@bl-young

Copy link
Copy Markdown
Member Author

I think we have to or we need to revert #458 for now

@bl-young

Copy link
Copy Markdown
Member Author

Why don't we hold and discuss tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants