Add V inflation flag to full model yaml#460
Draft
jvendries wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 5, 2026
…cornerstone_q to not inflate so it stays in 2017 USD
Member
|
Test is fixed but I question now the intent of derive_cornerstone_q_and_vnorm_for_year() when vnorm is not changing from 2017. |
jvendries
changed the base branch from
move_disagg_code_from_cornerstone_derived_functions
to
graphite-base/460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: #461
Closes:
What changed? Why?
The
apply_inflation_to_Vflag has been added to the 2025 USA Cornerstone full model configuration. This enables inflation adjustment to be applied to the V matrix as part of the model's calculation pipeline.Testing
Verify that running the 2025 USA Cornerstone full model with this configuration applies inflation adjustments to V as expected and that model outputs reflect the change.