Force encoding of blurbs download#26
Open
nmk wants to merge 1 commit intocopycopter:masterfrom
nmk:master
Open
Force encoding of blurbs download#26nmk wants to merge 1 commit intocopycopter:masterfrom nmk:master
nmk wants to merge 1 commit intocopycopter:masterfrom
nmk:master
Conversation
…istics fail to recognize it as such
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our case the JSON::parse heuristics were not correctly recognizing the encoding of the response body. The simplest way to remedy this is to explicitly mark the body as being in UTF-8.
A more robust approach would be to check the response's content-type header and extract the encoding from there. I would give this a try if the copycopter server is able to set the encoding to anything else than UTF-8. Otherwise I would just leave it hardcoded as is.