-
Notifications
You must be signed in to change notification settings - Fork 1
test implement #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test implement #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d2fcc3576
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
|
|
||
|
|
||
| model[:time_grid] = () -> range(t0, value(tf), N+1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use integer length in time_grid
N is defined via @expression(model, N, grid_size), so it becomes a JuMP expression, not an Int. Using range(..., N+1) will throw a MethodError when model[:time_grid]() is called because range expects an integer length. Other JuMP models in this repo use grid_size+1 for this reason, so any caller that inspects the time grid (plotting, postprocessing) will fail here.
Useful? React with 👍 / 👎.
No description provided.