fix(fetch): keep no_proxy suffix matches on domain boundaries#12603
fix(fetch): keep no_proxy suffix matches on domain boundaries#12603devYRPauli wants to merge 1 commit into
Conversation
💡 Codex ReviewWhen the CLI is not logged in, Line 1136 in 1fff91b This new handler replaces the old https://github.com/continuedev/continue/blob/1fff91ba962456d71198dbba66b0a76cb34bfe03/docs-site/app/[[...slug]]/page.tsx#L69-L71 Internal docs links elsewhere go through ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
NO_PROXY=.example.comwas matching unrelated hostnames likebadexample.combecause the suffix matcher stripped the leading dot before callingendsWith. The same issue affected configuredrequestOptions.noProxypatterns and port-qualified suffixes.This keeps the existing behavior where
.example.commatches bothexample.comand subdomains, but requires subdomain matches to end with.example.comso lookalike sibling domains do not bypass the proxy.Proof:
npm test -- src/util.test.tsfailed 5 new boundary assertions onbadexample.com,contest.com, andnotinternal.net:8443.npm test -- src/util.test.tspassed, 31/31.npm testpassed, 97/97.npm run buildpassed for@continuedev/fetchafter building the linked local@continuedev/config-typespackage.Summary by cubic
Fixes NO_PROXY suffix matching to enforce domain boundaries in
@continuedev/fetch..example.comnow matchesexample.comand subdomains only, not lookalikes likebadexample.com(with or without ports).Written for commit 1fff91b. Summary will update on new commits.