fix: Standardize status icons and colors app-wide - #67
Open
marekdano wants to merge 1 commit into
Open
Conversation
Signed-off-by: Marek Dano <mk.dano@gmail.com>
vishu-bh
requested changes
Aug 21, 2026
vishu-bh
left a comment
vishu-bh
left a comment
Contributor
There was a problem hiding this comment.
Solid PR!!
One thing to check src/components/mcp-servers/AdvancedSettings.tsx: still uses TriangleAlert. Should it use STATUS_ICON.warning?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #62
Summary
Standardizes the four status severities (success/info/warning/error) on the icon set already used in
ui/sonner.tsx(CircleCheckIcon/InfoIcon/TriangleAlertIcon/OctagonXIcon), and adds semantic--success/--warningCSS tokens alongside the existing--destructive, so color and glyph choices no longer drift per call site.src/lib/status.ts— a singleSTATUS_ICON/STATUS_TONE_CLASSlookup keyed by severity; most call sites now consume it instead of picking an icon/color ad hoc.--success/--warningtokens (light + dark) inindex.css, wired intobadge.tsxandStatusDot.tsx.StatusHeadline.tsxwhere warning and error rendered the identicalAlertTriangleicon.CheckCircle2,AlertTriangle,AlertCircle,XCircle,CircleAlert) onto the canonical set, and replaced raw Tailwind shades (green-500,emerald-500,yellow-300/500/600,red-500) with the semantic tokens across 17 components.CircleAlert); it's nowInfoIcon.Test plan
npm run lint,tsc -b,npm run format:checkall cleanvitest run— 184 files / 3062 tests passing (updated 2 tests that asserted old raw color classes; addedsrc/lib/status.test.tsfor the new lookup)