fix: remove node_type_registry from metaschema-schema (belongs in constructive-db only)#73
Merged
Merged
Conversation
…structive-db only) The node_type_registry table and seed fixture are not referenced by any code in pgpm-modules. They are only consumed at runtime in constructive-db (rls_parser, embedding_chunks_trigger). Removing to keep pgpm-modules lean.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
node_type_registrytable and seed fixture frompackages/metaschema-schema. This table is not referenced by any code in pgpm-modules — it's only consumed at runtime in constructive-db (byrls_parserandembedding_chunks_trigger).Changes:
node_type_registry/tableandnode_type_registry/fixtures/node_type_registry_seedpgpm.planReview & Testing Checklist for Human
node_type_registryat runtimenode_type_registrytable definition (it does — inpackages/metaschema)Notes
metaschema-schemaandmetaschema-modulestests pass locally after this removalpgpm packageto match the currentpackage.jsonversionLink to Devin session: https://app.devin.ai/sessions/8820b639fbd94ac8bfae86cfb01cf827
Requested by: @pyramation