[NA] docs(agents): wire frontend-design-fidelity into the automated reviewer#7436
Draft
aadereiko wants to merge 1 commit into
Draft
Conversation
…eviewer The frontend-design-fidelity skill (#7435) was orphaned — nothing in the review flow referenced it, so it only ran when manually invoked. Reference it from the Frontend review criteria in both the /review-github-pr command and the code-reviewer agent, so its design-drift checks run automatically on every apps/opik-frontend change. Docs-only. The ESLint token guardrail (tailwindcss/no-arbitrary-value + raw-hex) is intentionally NOT included here: the FE lint runs with --max-warnings=0 and there are ~666 pre-existing arbitrary-value usages, so enabling it now would break CI. It needs a separate cleanup-then-enforce pass (tracked as a follow-up). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
🔵 size/XS
documentation
Contributor
⏱️ pre-commit per-hook timingNo linted files changed — nothing to run. ⏭️ 41 skipped (no matching files changed)
|
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Wires the
frontend-design-fidelityskill (added in #7435) into the automated review flow. Adds a Design fidelity item to the Frontend review criteria in both.agents/commands/comet/review-github-pr.mdand.agents/agents/code-reviewer.md.The skill was orphaned — nothing in the review flow referenced it, so it only applied when manually invoked. This makes its design-drift checks part of the standard criteria that run automatically on any
apps/opik-frontend/**change, so the design team's most-repeated comments (variant/size, typography scale, tokens vs raw hex/px, missing states, tooltips, dark-mode contrast) get caught before a designer sees them.Based on #7435 so the referenced
SKILL.mdexists in the diff base — merge #7435 first, or merge them together. Docs-only — no runtime code changes.Change checklist
Issues
[NA])AI-WATERMARK
AI-WATERMARK: yes
Testing
Docs-only; no code paths. Verified via grep that
frontend-design-fidelitywas referenced only by the skill file + README before this change, and now also by the reviewer command and agent.Documentation
Updates internal agent/review documentation only. No external/product docs affected.