New Feature : conflicting claims by YashKumarVerma · Pull Request #279 · coding-blocks/boss

YashKumarVerma · 2020-05-18T08:36:35Z

Shows a list of conflicting claims made by various users in the sidebar
Provision to match URLs who differ only in the protocol, trailing slashes, ports, hashes, query strings etc
Inline documentation added for codebase edits
All errors inside route handled

Preview

Raw data used to build page
When there are no conflicts
When conflicts arise

0xnmn · 2020-05-18T14:56:15Z

utils/datautils.js

  return db.Claim.findById(claimId)
 }

+function getConflictingClaimByPr(pullRequestId) {


Not the correct logic. just checking the presence of id does not decide the id is for pr or issue.

I think i named the parameter wrongly in this one.
for a the url
https://github.com/coding-blocks/boss/pull/279
this is the value of the parameter
coding-blocks/boss/pull/279
and not only 279

The caller function does not search for id only, it searches for full generic URL :
boss/pull/279

This checks the unique part of the URL, which is of the type user/repository/pull/id. The above confusion arose due to improper variable naming, which I've fixed now.

routes/root.js

0xnmn · 2020-05-18T14:58:23Z

routes/root.js

+    let response, conflicts
+
+    /**
+     * the database has internal checks for duplicate items in the pull request column


does not cover all the cases.

could you please mention which type of case is not handled

YashKumarVerma · 2020-05-19T18:59:02Z

@hereisnaman, @championswimmer waiting for review

0xnmn · 2020-05-19T19:45:01Z

@hereisnaman, @championswimmer waiting for review

Reviews usually take from 1-3 days. You can start working on other issues.

YashKumarVerma · 2020-05-23T05:50:55Z

Awaiting review.

YashKumarVerma · 2020-05-24T10:32:45Z

~~Requesting someone to carry it forward~~

YashKumarVerma · 2020-05-29T20:09:06Z

A few thigns to mention:

if only the number is matched using a wildcard, then issue 10 will show conflicts with 100, 101, 102...
if it will be assumed that the issue / pr id will be followed by a slash or terminate immediately, it's also a wrong lead, as URLs ending with hashes are also submitted

Working on a solution of the above problems.

0xnmn · 2020-05-30T01:35:55Z

A few thigns to mention:

* if only the number is matched using a wildcard, then issue 10 will show conflicts with 100, 101, 102...

* if it will be assumed that the issue / pr id will be followed by a slash or terminate immediately, it's also a wrong lead, as URLs ending with hashes are also submitted

Working on a solution of the above problems.

What is the use case behind having urls with hashes? Can't we clean them in the add claim form?

YashKumarVerma · 2020-05-30T03:22:41Z

A few thigns to mention:
* if only the number is matched using a wildcard, then issue 10 will show conflicts with 100, 101, 102...

* if it will be assumed that the issue / pr id will be followed by a slash or terminate immediately, it's also a wrong lead, as URLs ending with hashes are also submitted
Working on a solution of the above problems.
What is the use case behind having urls with hashes? Can't we clean them in the add claim form?

We should surely add checks in the form where new claim is added, but the problem is, We already have entries like this.

So either we update the entries like these, or we accommodate things like this in the conflicts code. In any of these cases, we still need to add checks in the input form

0xnmn · 2020-05-30T04:00:05Z

@YashKumarVerma can you first create a PR with the following:

in add claim api, clean the urls, removing all the hashes, query params and add trailing slash.
write a script to transform the current items for the same.

I'll give you separate points for that.

YashKumarVerma · 2020-05-30T04:27:46Z

@YashKumarVerma can you first create a PR with the following:

in add claim api, clean the urls, removing all the hashes, query params and add trailing slash.

write a script to transform the current items for the same.

I'll give you separate points for that.

@hereisnaman I wrote the script but there's one issue we need to tackle.
The pullUrl column is set as unique, so if there exist entries with and without trailing slash, it will throw error and not let us update it.

An alternative approach can be that we

do not fix the old claims (as removing the slash and # would cause conflicts in db as the column is set to unique in the schema and ideally, we should not change that)
we check new claims that are made, and make sure that the above point is not repeated in new claims.
in the conflicting claims page, we write the code to handle the cases like these (I've found a workaround for it)

YashKumarVerma · 2020-05-30T17:30:02Z

With #390 sent, now we can create a more robust conflict view.
Reasons:

There are multiple PRs sent for the same issue. we need to list them.
Shows number of PRs for single issue submitted on BOSS portal
There are
- 100 claims which have the same URL submitted for both handles.
- 140 claims which have different URLs submitted

admins must have a complete view of where all were the issues and pull requests submitted

YashKumarVerma · 2020-05-30T20:20:46Z

Carried forward in #392

YashKumarVerma mentioned this pull request May 18, 2020

Reject all the conflicting claims on accepting one #261

Open

0xnmn suggested changes May 18, 2020

View reviewed changes

YashKumarVerma mentioned this pull request May 18, 2020

Add conflicting claims section on accept claims page #260

Closed

feat: conflicting claims : Fixes coding-blocks#260

14c7ec0

YashKumarVerma force-pushed the claims branch from 6ad5b9f to 14c7ec0 Compare May 18, 2020 23:40

YashKumarVerma requested a review from 0xnmn May 18, 2020 23:42

YashKumarVerma closed this May 24, 2020

YashKumarVerma reopened this May 29, 2020

YashKumarVerma mentioned this pull request May 30, 2020

Ensure new claims do not send non-standard inputs #390

Open

YashKumarVerma mentioned this pull request May 30, 2020

Conflict Analysis on Claim Review #392

Closed

Conversation

YashKumarVerma commented May 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview

Uh oh!

0xnmn May 18, 2020

Choose a reason for hiding this comment

Uh oh!

YashKumarVerma May 18, 2020

Choose a reason for hiding this comment

Uh oh!

YashKumarVerma May 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YashKumarVerma May 19, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0xnmn May 18, 2020

Choose a reason for hiding this comment

Uh oh!

YashKumarVerma May 18, 2020

Choose a reason for hiding this comment

Uh oh!

YashKumarVerma commented May 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xnmn commented May 19, 2020

Uh oh!

YashKumarVerma commented May 23, 2020

Uh oh!

YashKumarVerma commented May 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YashKumarVerma commented May 29, 2020

Uh oh!

0xnmn commented May 30, 2020

Uh oh!

YashKumarVerma commented May 30, 2020

Uh oh!

0xnmn commented May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YashKumarVerma commented May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YashKumarVerma commented May 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YashKumarVerma commented May 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

YashKumarVerma commented May 18, 2020 •

edited

Loading

YashKumarVerma May 18, 2020 •

edited

Loading

YashKumarVerma commented May 19, 2020 •

edited

Loading

YashKumarVerma commented May 24, 2020 •

edited

Loading

0xnmn commented May 30, 2020 •

edited

Loading

YashKumarVerma commented May 30, 2020 •

edited

Loading

YashKumarVerma commented May 30, 2020 •

edited

Loading