feat: add WaitForRunningStep and GetPipelineState method for pipeline status checks#375
Open
OliverTrautvetter wants to merge 9 commits into
Open
feat: add WaitForRunningStep and GetPipelineState method for pipeline status checks#375OliverTrautvetter wants to merge 9 commits into
OliverTrautvetter wants to merge 9 commits into
Conversation
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Codesphere smoketest workflow to actively poll pipeline status after starting the run stage, by adding a new WaitForRunningStep and introducing a GetPipelineState method on the Codesphere client abstraction.
Changes:
- Added
Client.GetPipelineState(andAPIClientimplementation) to retrieve pipeline stage status. - Introduced a new smoketest step
waitForRunningthat polls until the pipeline stage reportsrunning(or fails on terminal states). - Updated CLI step registration, docs, mocks, and added/adjusted tests to cover the new step and failure/aborted states.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/codesphere/teststeps/csgo.go | Adds WaitForRunningStep polling logic and related constants. |
| internal/codesphere/codesphere.go | Extends the Codesphere client interface and API wrapper with GetPipelineState. |
| internal/codesphere/mocks.go | Updates generated mock to include GetPipelineState. |
| cli/cmd/smoketest_codesphere.go | Registers WaitForRunningStep in the default smoketest step list. |
| cli/cmd/smoketest_codesphere_test.go | Updates the happy-path mock run and adds tests for failure/aborted pipeline states. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
….com/codesphere-cloud/oms into smoketest_workspace_is_running_check
…age step in smoketest
Signed-off-by: OliverTrautvetter <66372584+OliverTrautvetter@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoketests should validate if workspace was actually created
Clickup