🤖 fix: use single electron-builder command for macOS multi-arch builds #1358
+4
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous approach ran two separate electron-builder commands sequentially: 1. `--mac --x64 --publish always` 2. `--mac --arm64 --publish always` This caused the second command to overwrite `latest-mac.yml` with only arm64 artifacts, breaking auto-update for x64 Mac users (they'd get ERR_UPDATER_ZIP_FILE_NOT_FOUND). Fix: Use a single `--mac --x64 --arm64 --publish always` command which: - Generates a unified `latest-mac.yml` containing both architectures - Still builds sequentially internally (no keychain conflicts) - Simpler and more maintainable (-18 lines) Ref: electron-builder#5592
- dist-mac: parallel when CSC_LINK unset (faster local dev), unified when set - dist-mac-release: always unified (releases need correct latest-mac.yml)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The macOS release build ran two separate
electron-buildercommands:--mac --x64 --publish always--mac --arm64 --publish alwaysThe second command overwrote
latest-mac.ymlwith only arm64 artifacts. This broke auto-update for x64 Mac users—they'd getERR_UPDATER_ZIP_FILE_NOT_FOUNDbecause electron-updater filters byprocess.archand finds no matching files.Solution
Use a single
--mac --x64 --arm64 --publish alwayscommand which:latest-mac.ymlcontaining both architecturesRef: electron-builder#5592
Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high