feat(terminal): support top and bottom split_side - #312
Open
giuxtaposition wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
topandbottomtoterminal.split_side(previouslyleft/rightonly). Horizontal splits reuseterminal.split_width_percentage(and diff-timeterminal.diff_split_width_percentage) as a fraction ofvim.o.linesinstead ofvim.o.columns. Diff opening, closing, and new-tab teardown all pick the correct axis andwincmdper side.left/rightbehavior unchanged.create_splithelper pickssplit/vsplitandtopleft/botrightper side; replaces two near-duplicate placement blocks inopen_terminalandshow_hidden_terminal.resize_terminal_for_diffreadssplit_sideand callsnvim_win_set_heightfor top/bottom,nvim_win_set_widthfor left/right.wincmdmove (H/L/K/J) and post-layout jump (h/l/j/k) picked from a small lookup table.resolve_split_width_percentage→resolve_terminal_split_fraction(config keys keep their historical names; public API unchanged).types.lua: newClaudeCodeSplitSidealias covers all four values.Usage
Test plan
Related issues
Closes #153
Some screenshots