Repository navigation
Deprecate HumanIntervention::AuthenticationSystem - #80
Open
minerva-sky wants to merge 1 commit into
Open
minerva-sky wants to merge 1 commit into
minerva-sky wants to merge 1 commit into
Conversation
Single SHA-256 round labelled pbkdf2_sha256, == secret comparison, and accounts in a gem whose charter excludes them. Authenticator now warns under the :deprecated category; removal lands next minor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58 (step 1 of 2: deprecate now, remove next minor).
AuthenticationSystemlabels one SHA-256 round aspbkdf2_sha256/100000, compares secrets with==, and is an accounts system in a gem whose charter says no accounts. Fixing the primitive would mean maintaining a password hasher we shouldn't own, so this deprecates it instead.@deprecatedYARD tag on the classAuthenticator#initializewarns under the:deprecatedcategory (silent unlessWarning[:deprecated]is on, the Ruby convention, so the Portal's default construction doesn't spam)DeprecatedentryThis went up on lazy consensus: the contract-calls ask passed 2026-10-25 with no reply. Your merge gate hasn't changed. If you'd rather keep the class and fix the primitive, say so and I'll swap this for that PR.
🤖 Generated with Claude Code