Open
Conversation
|
|
EdwardJXLi
reviewed
Mar 5, 2025
Contributor
EdwardJXLi
left a comment
There was a problem hiding this comment.
Hey there! Overall LGTM. Do you mind merging in from latest develop again? There's a couple changes that would fix the failing tests.
After that and the CLA check, I can then approve the pr 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Many usages of
iter_filesdon't explicitly includeskip_content, but they don't actually care about the contents of the files. This can slow down codegen when running against a large repository with many large files.Content
This PR just adds
skip_contentto all of theiter_filesreferences I could find which don't care about the file content.Note that this...actually is all of the references. The more "right" way to do this may be to change
iter_filesto never return the contents of files, but I didn't want to make that kind of change w/o talking to the maintainers first.Testing
Best-effort testing locally. Would like to chat w/ y'all to figure out how to effectively test a change like this.
Please check the following before marking your PR as ready for review