Repository navigation
fix(graphql): Add deprecated pullBase field to Pull type - #2458
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2458 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 1341 1341
Lines 53342 53343 +1
Branches 1649 1649
=======================================
+ Hits 48888 48889 +1
Misses 4133 4133
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an unhandled
GraphQLErroroccurring when external clients query the non-existentpullBasefield on thePullGraphQL type.The
pullBasefield has never existed in our schema; the closest historical field wasbase, which was renamed tocomparedToin October 2021. To prevent these errors and provide backward compatibility for external consumers, this change introducespullBaseas a deprecated field that aliases tocomparedTo.Changes:
pullBase: Commit @deprecated(reason: "Use comparedTo")toapps/codecov-api/graphql_api/types/pull/pull.graphql.apps/codecov-api/graphql_api/types/pull/pull.pyto use the existingresolve_baseresolver for bothcomparedToand the newpullBasefield.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-F7D
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Note
Low Risk
Read-only GraphQL compatibility shim with no changes to auth, persistence, or comparison behavior beyond exposing an alias field.
Overview
Adds a deprecated
pullBasefield on the GraphQLPulltype so clients that still requestpullBasestop hitting schema errors; it returns the same base commit ascomparedTo, with deprecation directing callers tocomparedTo.The Python resolver for
comparedTois also registered forpullBase, so both fields share the existingresolve_baselogic (loading the commit viaCommitLoaderfrompull.compared_to).Reviewed by Cursor Bugbot for commit 7f36969. Bugbot is set up for automated code reviews on this repo. Configure here.