Repository navigation
fix(graphql): filter invalid schema queries from Sentry - #2455
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2455 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 1341 1341
Lines 53342 53344 +2
Branches 1649 1649
=======================================
+ Hits 48888 48890 +2
Misses 4133 4133
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the GraphQL error formatter to prevent logging and capturing client-side schema validation errors (e.g., querying non-existent fields) in Sentry. Previously, anonymous external clients making such invalid queries would trigger Sentry events, creating unnecessary noise.
The
error_formatterinapps/codecov-api/graphql_api/views.pynow includes an explicit check foris_bad_query(indicating a schema validation error) and returns the masked error response without logging or capturing the exception in Sentry. The response to the client remains a genericINTERNAL SERVER ERRORto avoid leaking schema details.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-F78
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.
Note
Low Risk
Observability-only change in error handling; no change to GraphQL responses or auth paths.
Overview
GraphQL invalid-field queries no longer hit Sentry or error logs.
The
error_formatteringraphql_api/views.pyalready treats"Cannot query field"messages as client mistakes and masks them as a generic internal error for most callers. This PR adds an explicitelif is_bad_querybranch so those cases skiplog.errorandcapture_exception, which previously ran when the underlying error was not a known app exception type.Client-facing behavior is unchanged: anonymous or masked responses still avoid leaking schema details.
Reviewed by Cursor Bugbot for commit 3dc73af. Bugbot is set up for automated code reviews on this repo. Configure here.