Repository navigation
fix(login): remove unnecessary Suspense causing DOM error - #4132
sentry[bot] wants to merge 1 commit into
Conversation
Bundle ReportChanges will decrease total bundle size by 340 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
|
|
Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4132 +/- ##
==========================================
- Coverage 98.77% 98.77% -0.01%
==========================================
Files 823 823
Lines 15147 15145 -2
Branches 4387 4387
==========================================
- Hits 14961 14959 -2
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4132 +/- ##
==========================================
- Coverage 98.77% 98.77% -0.01%
==========================================
Files 823 823
Lines 15147 15145 -2
Branches 4387 4379 -8
==========================================
- Hits 14961 14959 -2
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Harness.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #4132 +/- ##
==========================================
- Coverage 98.77% 98.77% -0.01%
==========================================
Files 823 823
Lines 15147 15145 -2
Branches 4379 4379
==========================================
- Hits 14961 14959 -2
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4132 +/- ##
==========================================
- Coverage 98.77% 98.77% -0.01%
==========================================
Files 823 823
Lines 15147 15145 -2
Branches 4387 4379 -8
==========================================
- Hits 14961 14959 -2
Misses 179 179
Partials 7 7
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
1 participant
Description
This PR addresses the
NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.occurring on the/loginpage.Root Cause:
The error stemmed from a conflict between Sentry Session Replay's (rrweb) DOM patching and React's Suspense boundary cleanup. The
LoginLayoutcomponent wrapped its children in a<Suspense>boundary, which created comment nodes in the DOM. When React attempted to clean up these nodes after the (eagerly loaded)LoginPagerendered, rrweb's monkey-patchedremoveChildfunction failed because its internal DOM representation had diverged, leading to theNotFoundError.Solution:
The
<Suspense>boundary inLoginLayoutwas unnecessary, as theLoginPagecomponent is eagerly imported and never actually suspends. By removing the<Suspense fallback={<FullPageLoader />}>wrapper fromLoginLayout.tsx, we eliminate the source of the DOM reconciliation conflict.Code Example
Notable Changes
<Suspense>boundary fromLoginLayout.tsx.FullPageLoadercomponent.LoadingLogoimport.Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes GAZEBO-187F
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.