Release mechanism cleanup: fix deprecation warnings and remove dead code - #919
Open
dominiquemetz wants to merge 3 commits into
Open
Release mechanism cleanup: fix deprecation warnings and remove dead code#919dominiquemetz wants to merge 3 commits into
dominiquemetz wants to merge 3 commits into
Conversation
Update the upload job in release-charts.yaml to use action versions that target Node.js 24 (resolving the Node.js 20 deprecation warning) and no longer rely on the deprecated command: - actions/checkout v2 -> v7 (node24) - azure/setup-helm v1 -> v5 (node24; v1 was on node12) - docker/login-action v3 -> v4 (node24) - helm/chart-releaser-action v1.5.0 -> v1.7.0 (uses $GITHUB_OUTPUT) The `version` (setup-helm) and `charts_dir` (chart-releaser) inputs are unchanged, so workflow behavior is preserved. Signed-off-by: Dominique Metz <dominique.metz@codecentric.de>
Drop the commented-out automatic triggers (push/cron), the entire bump-versions job, and the needs/if gating on the upload job. These referenced the abandoned auto-bump mechanism (actions/checkout@v2 plus the custom bumpVersionAction, which uses the deprecated set-output) and would reintroduce the warnings fixed in the previous commit if uncommented. Keep a one-line comment documenting the manual-bump policy next to the trigger it explains. Signed-off-by: Dominique Metz <dominique.metz@codecentric.de>
Delete the bumpVersionAction custom action (action.yml, bump-version.py, Dockerfile, README) and the per-chart .bumpversion.cfg files for keycloak, keycloakx, and mailhog. Nothing references these since the automatic version-bump job was removed from the release workflow. Also update the pull request template: it still told contributors that version bumps happen automatically based on commit-message keywords (major/feat/chore) and pointed at a scripts/bump-version.py path that never existed. Rewrite it to reflect the current manual-bump policy. Signed-off-by: Dominique Metz <dominique.metz@codecentric.de>
dominiquemetz
force-pushed
the
release-mechanism-cleanup
branch
from
August 18, 2026 08:01
5be7141 to
bee6991
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The `release-charts` workflow's `upload` job emitted two deprecation warnings on every run. While fixing them, the surrounding dead code from the abandoned automatic version-bump mechanism turned out to be intertwined, so this PR cleans up the whole release mechanism in one go.
What & why
1. Fix deprecation warnings (commit `c536a78`)
The `upload` job used action versions targeting Node.js 20 (deprecated on GitHub Actions runners) and the deprecated `set-output` command. Bumped to the latest majors, all of which run on Node.js 24 and use `$GITHUB_OUTPUT`:
Inputs used by this workflow (`version`, `charts_dir`) are unchanged across these versions, so behavior is preserved.
2. Remove dead code from the release workflow (commit `fce3ad5`)
Removed from `.github/workflows/release-charts.yaml`:
These were all part of the abandoned auto-bump mechanism and referenced `actions/checkout@v2` plus the custom `bumpVersionAction` — uncommenting them would have reintroduced both deprecation warnings. A one-line comment documents the current manual-bump policy next to the trigger it explains.
3. Remove orphaned auto-bump infrastructure (commit `5be7141`)
With the bump job gone, the following were unreferenced and are deleted:
Also rewrote `.github/pull_request_template.md`, which still told contributors that version bumps happen automatically based on commit-message keywords (`major`/`feat`/`chore`) and linked to a `scripts/bump-version.py` path that never existed. It now reflects the manual-bump policy.