feature: add gatewayapi support in mailhog - #906
Conversation
Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com>
Signed-off-by: Andrija Pantovic <andrija.pantovic@gmail.com>
pantovad
changed the title
dominiquemetz
left a comment
dominiquemetz
left a comment
There was a problem hiding this comment.
Hi, thank you for the contribution!
The implementation looks good overall, and I've left some inline comments on specific lines.
For the documentation, please update the README to cover the new gatewayapi section in values.yaml, including all fields and their purpose. Please also make sure to document that this feature uses ListenerSet, which as of June 2026 is only supported by Envoy Gateway v1.8+. No other Gateway controller implements it yet.
| value: {{ .path }} | ||
| backendRefs: | ||
| - name: {{ $fullName }} | ||
| port: 8025 |
There was a problem hiding this comment.
This should be {{ .Values.service.port.http }} right?
| value: {{ .path }} | ||
| backendRefs: | ||
| - name: {{ $fullName }} | ||
| port: 8025 |
There was a problem hiding this comment.
This should be {{ .Values.service.port.http }} right?
| gatewayapi: | ||
| enabled: false | ||
| gateway: | ||
| name: envoy-gateway |
There was a problem hiding this comment.
We don't want to assume a specific controller. Please leave this empty
| # - secretName: chart-example-tls | ||
| # hosts: | ||
| # - chart-example.local | ||
| gatewayapi: |
There was a problem hiding this comment.
Please provide an example for the tls block when using the Gateway for completions sake
|
@pantovad Can you make the requested adjustments? |
|
This pull request has been marked as stale because it has been open for 30 days with no activity. It will be automatically closed in 10 days if no further activity occurs. |
3 participants
Add support for Gateweay API in Mailhog chart