Repository navigation
chore(contract): sync flipcash2 protos to 9f67566 - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs flipcash2 protos from
9d44350bto9f67566f(flipcash2-protobuf-api #139). The only change is a doc comment onStartChatRequest's public-grouprulesfield. There are no field, RPC, message or enum changes, so 0.18.0 consumers are unaffected.The new comment documents server validation that is already live:
MinimumBalanceRequirement, which is required, and optionally oneStaffRequirement.MinimumBalanceRequirement. It must use the same currency and mints as the listener requirement and be larger by at least the currency's minimum transfer value.MinimumBalanceRequirementmust be at least one unit at the currency's last decimal place (0.01 USD, 1 JPY).INVALID_RULES. A creator who doesn't meet them getsRULES_NOT_SATISFIED.No release follows this PR. A comment isn't worth a Maven Central version, so it ships with the next contract change, and
CHANGELOG.mdgets no entry yet.Neither app needs adoption work. Both send one listener minimum balance and no speaker rules. Android can still send a sub-cent minimum, which the server rejects under the rule above. The fix is going into code-android-app separately.