Repository navigation
feat(onboarding): restrict display name to ASCII letters, digits, and spaces - #933
Merged
Merged
Conversation
… spaces Add an opt-in asciiOnly mode to DisplayNameValidator and enable it for the onboarding name step only. The default validator is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During onboarding, the display name is now accepted only if, after trimming, it is 1–64 characters of
A-Z,a-z,0-9, or a space (U+0020). Any other name makesvalidatedDisplayNamenil, so Next stays disabled, as it already does for an empty name.ProfileCreationStateand the other name screens keep the existing rule.DisplayNameValidatorgetsinit(asciiOnly: Bool = false).init()behaves as before.OnboardingNameViewModelusesDisplayNameValidator(asciiOnly: true).remainingCharactersstill counts trimmed scalars, which for ASCII equals characters.Android applies the same rule in code-payments/code-android-app#1641.
DisplayNameValidatorTestsadds ASCII-only cases: accepted, trimmed, and double-space names; rejected accents, punctuation, emoji, tab, NBSP, all-space, and 65-letter names; and"José"still accepted by the default validator../Scripts/test.sh FlipcashCoreTests/DisplayNameValidatorTests: 10 passed.