feat(menu): show username card for auto-assigned handles - #1643
Merged
Merged
Conversation
The custom-username card only appeared for accounts with no handle, so a user whose handle the server assigned never got the nudge to pick their own. usernameGate now takes isAutoAssigned and treats an assigned handle as unclaimed; the balance and minimum rules are unchanged. The view model passes UserProfile.isUsernameAutoAssigned through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Menu screen's custom-username card only showed when the profile had no username. A user whose handle the server auto-assigned when they set a display name never saw it, so nothing prompted them to pick their own.
usernameGate()now takesisAutoAssigned, and a handle counts asClaimedonly when it is non-blank and not auto-assigned.MenuScreenViewModelpassesUserProfile.isUsernameAutoAssignedthrough to the gate.The card hides again once the user picks a handle, because
ProfileControlleralready clears the flag locally onSetUsername. Tapping the card opens the username screen with the assigned handle prefilled and editable.Tests: two new
UsernameGateTestcases, covering an auto-assigned handle counting as unclaimed and following the same balance rules as having no handle.iOS counterpart: code-payments/code-ios-app#935