test(amount-entry): cover hint freeze while sending - #1642
Merged
Merged
Conversation
AmountEntryDelegate.config keeps the last idle config while the host is loading or has succeeded, so the "$X available" hint doesn't jump to the post-send balance and turn red before the sheet dismisses. The existing tests only checked that loadingState passes through to the action; nothing asserted the freeze. The new test enters 99 against a max of 100.77, drops the max to 1.78 during loading, and checks the Info hint holds through loading and success, then turns into the over-max Error once loadingState is idle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AmountEntryDelegate.configkeeps the last idle config while the host is loading or has succeeded (thescanadded in 132896a). Chat send, Give cash, Swap and Withdraw all rely on it to stop the "$X available" hint from jumping to the post-send balance and turning red before the sheet dismisses. That's the bug iOS shows today. The existing tests inAmountEntryDelegateTestandAmountEntryConfigTestonly check thatloadingStatereaches the action, so removing the freeze would not fail anything.The new test in
AmountEntryDelegateTestwalks one send:Info.loading = true, max drops to 1.78: hint is unchanged, action shows loading.success = true, max still 1.78: hint is unchanged, action shows success.Error.