feat(navigation): label the tab bar - #1629
Merged
Merged
Conversation
bmc08gt
force-pushed
the
feat/tab-bar-labels
branch
2 times, most recently
from
September 30, 2026 16:36
3d8f200 to
a82c7d5
Compare
Adds a name under each tab glyph (Scan, Chat, Wallet, You) per node 10642:1325, and titles the Chat screen "Chat" from the same string. - The name uses caption with its 18sp line height dropped. The theme has no 10sp token for the design's Demi 10 on a 12pt line. - Glyph and name share a column padded 5dp top and bottom, and the selected pill takes the row's height. Glyphs are 28dp to match the design. - The bar is inset 25dp from each screen edge (the design's 24pt). The old 40dp inset left each item nearly square, so the pill read as a circle. - As on the iOS bar, the selected pill reaches past its item, 10dp on each side, into matching side padding in the bar. The extra width keeps a "99+" badge inside the pill's round ends. - The unread badge follows node 10599:65444: 17.5dp tall, starting 16dp into the glyph and rising 3.25dp above it. Longer counts grow right from that start. The glyph's box is fixed to its size so a wide badge can't pull the glyph off centre.
bmc08gt
force-pushed
the
feat/tab-bar-labels
branch
from
September 30, 2026 16:40
a82c7d5 to
b5b7804
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a name under each tab glyph, in tab order Scan, Chat, Wallet, You, per node 10642:1325, and titles the Chat screen "Chat" from the same string. The labels always show; the iOS bar's fold-on-scroll is left for a later change.
What changes
:apps:flipcash:core, set in white and dimmed with the rest of the item when unselected. The design sets them in Demi 10 on a 12pt line (node 10599:65384). The theme has no 10sp token, so the name usescaptionwith its 18sp line height dropped, which keeps the text box tight under the glyph instead of adding a one-off style.staticGrid.x1(5dp), and the selected pill takes the row's height, so it frames both.grid.x8, which is 40dp at the normal width class and left each item nearly square, so the pill read as a circle. It is nowstaticGrid.x5(25dp).staticGrid.x2) on each side, into matching side padding in the bar. The extra width keeps a "99+" badge inside the pill's round ends.Why no scroll fold
An earlier revision folded the labels away while a tab scrolled down. It resized the bar and its haze blur on every animation frame, and a scroll that kept folding and unfolding ran at a 19ms median frame against 14ms on
code/cashon the same Seeker. It was dropped rather than tuned.