Repository navigation
chore(chat): remove unused legacy MessageList and MessageNode - #1615
Merged
Merged
Conversation
Messenger renders its transcript with its own internal MessageList, so the public MessageList in :ui:components had no callers, and MessageNode was only called from it. Everything under chat/messagecontents and chat/utils was reachable only through MessageNode, so it goes too, along with the drawables and ui/components strings that only those files used. MessageNodeDefaults moves to its own file because messenger's GatedTranscriptPlaceholder still uses it. MessageNodeOptions and MessageNodeScope are deleted: their only users were the removed messagecontents files.
github-actions
Bot
added
type: chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public
MessageListin:ui:componentshas no callers: messenger renders its transcript with its own internalMessageList.MessageNodewas only called from that legacy list, and everything underchat/messagecontentsandchat/utilswas reachable only throughMessageNode, so those go too. The drawables andui/componentsstrings that only those files used go with them.MessageNodeDefaultsmoves to its own file, since messenger'sGatedTranscriptPlaceholderstill uses it.MessageNodeOptionsandMessageNodeScopeare deleted because their only users were the removedmessagecontentsfiles.A few
ui/resourcesstrings andic_kin_white_smallare now unreferenced. They're left for a separate change because that module's strings are shared and partly localized.