fix(chat): put the muted chip under a person's profile actions - #1611
Merged
Merged
Conversation
On a DM's profile the chip sat above Message/Share, and since every person profile now has those actions it dropped its held line there, so muting pushed the actions and rows down. The actions now sit 25dp under the join date on every person profile, and the chip follows 16dp below them with its line held, so mute and unmute no longer move anything. Matches iOS (code-ios-app#897).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1608. Since that PR, every person's profile has the Share action, so on a DM's profile the muted chip dropped its held line (
reserveSpace = shortcuts == null) and muting pushed Message/Share and the rows below down by the chip's height.ProfileHeadernow draws the actions 25dp under the join date, then the chip 16dp under them with its line held, only on the DM's own person (whereviewerStateis passed). Muting and unmuting no longer move anything, and the actions sit at the same height on every person's profile.