chore(deps): bump github.com/sigstore/timestamp-authority/v2 from 2.0.6 to 2.1.0 - #310
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
The update of github.com/sigstore/timestamp-authority/v2 to version 2.1.0 successfully addresses specific metric label cardinality issues and specification violations in verification logic. However, high-severity security flaws have been identified in the current dependency tree. Specifically, golang.org/x/crypto and github.com/sigstore/rekor are at versions containing critical vulnerabilities, including potential unauthorized command execution and Denial of Service (OOM). These security risks should be remediated by upgrading the affected packages to their patched versions.
About this PR
- There is a systemic security risk identified in the Sigstore ecosystem dependencies being used. While one component is updated, others like Rekor remain at vulnerable versions, potentially leaving the application open to Denial of Service attacks.
Test suggestions
- Verify that timestamp verification logic remains compatible with the library's fixes for EKU and hash verification.
- Confirm the application builds and initializes correctly with the updated transitive dependencies for AWS and GCP.
- Verify that telemetry and metrics collection still operate as expected with the new bounded label cardinality.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that timestamp verification logic remains compatible with the library's fixes for EKU and hash verification.
2. Confirm the application builds and initializes correctly with the updated transitive dependencies for AWS and GCP.
3. Verify that telemetry and metrics collection still operate as expected with the new bounded label cardinality.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
| go.yaml.in/yaml/v4 v4.0.0-rc.3 // indirect | ||
| golang.org/x/crypto v0.50.0 // indirect | ||
| golang.org/x/crypto v0.51.0 // indirect |
There was a problem hiding this comment.
🔴 HIGH RISK
Updating golang.org/x/crypto to v0.51.0 leaves the project vulnerable to high-severity security issues affecting SSH signature verification and command execution (CVE-2026-42508, CVE-2026-39828, CVE-2026-39829). This version should be bumped to v0.52.0 to address these flaws.
| golang.org/x/crypto v0.51.0 // indirect | |
| golang.org/x/crypto v0.52.0 // indirect |
| @@ -309,9 +309,9 @@ require ( | |||
| github.com/sigstore/protobuf-specs v0.5.0 // indirect | |||
| github.com/sigstore/rekor v1.5.1 // indirect | |||
There was a problem hiding this comment.
🔴 HIGH RISK
The dependency github.com/sigstore/rekor is at v1.5.1, which contains a high-severity vulnerability (CVE-2026-48702) that allows for a Denial of Service (OOM) through unbounded gzip decompression. Given that this PR is updating Sigstore dependencies, it is recommended to bump Rekor to v1.5.2.
| github.com/sigstore/rekor v1.5.1 // indirect | |
| github.com/sigstore/rekor v1.5.2 // indirect |
Bumps [github.com/sigstore/timestamp-authority/v2](https://github.com/sigstore/timestamp-authority) from 2.0.6 to 2.1.0. - [Release notes](https://github.com/sigstore/timestamp-authority/releases) - [Changelog](https://github.com/sigstore/timestamp-authority/blob/main/CHANGELOG.md) - [Commits](sigstore/timestamp-authority@v2.0.6...v2.1.0) --- updated-dependencies: - dependency-name: github.com/sigstore/timestamp-authority/v2 dependency-version: 2.1.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
0436f1c to
b189111
Compare
|
Looks like github.com/sigstore/timestamp-authority/v2 is up-to-date now, so this is no longer needed. |
Pull request was closed
Bumps github.com/sigstore/timestamp-authority/v2 from 2.0.6 to 2.1.0.
Release notes
Sourced from github.com/sigstore/timestamp-authority/v2's releases.
Commits
58ae149Fix spec violations in policy, EKU, and hash verification (#1375)506ec57Bound path and HTTP method metric label cardinality to prevent OOM (#1374)ee10addchore(deps): bump the actions group with 2 updates (#1370)5238ec7chore(deps): bump golang.org/x/net from 0.54.0 to 0.55.0 (#1369)0ff73b8chore(deps): bump goreleaser/goreleaser-action in the actions group (#1367)97813cachore(deps): bump the actions group with 2 updates (#1366)ece88f8chore(deps): bump github.com/go-openapi/runtime from 0.30.0 to 0.31.0 (#1365)77e0ee5chore(deps): bump github.com/tink-crypto/tink-go-awskms/v2 to v3 (#1364)6ea07dfchore(deps): bump go.step.sm/crypto from 0.80.0 to 0.81.0 (#1363)f1dc03bchore(deps): bump github.com/tink-crypto/tink-go-hcvault/v2 (#1362)