Skip to content

refactor: CSS layer name and new tests#173

Merged
pan-kot merged 1 commit into
mainfrom
refactor-optimise-multi-selectors
May 27, 2026
Merged

refactor: CSS layer name and new tests#173
pan-kot merged 1 commit into
mainfrom
refactor-optimise-multi-selectors

Conversation

@pan-kot
Copy link
Copy Markdown
Member

@pan-kot pan-kot commented Apr 29, 2026

I changed the default layer name from "cloudscape-base-theme" to "awsui-base-theme" to be more generic - this matches the prefixes we use for design tokens and custom data attributes.

Additionally, I added new unit tests that ensure that runtime themes have priority over build time themes because the former do not include the CSS layer.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot changed the title Refactor optimise multi selectors refactor: Optimise multi selectors Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.58%. Comparing base (43861b7) to head (96948ed).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   97.57%   97.58%           
=======================================
  Files          48       48           
  Lines        2641     2651   +10     
  Branches      549      545    -4     
=======================================
+ Hits         2577     2587   +10     
  Misses         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot force-pushed the refactor-optimise-multi-selectors branch from 4957b22 to 96948ed Compare May 27, 2026 09:02
@pan-kot pan-kot changed the title refactor: Optimise multi selectors refactor: CSS layer name and new tests May 27, 2026
@pan-kot pan-kot requested a review from gethinwebster May 27, 2026 12:45
@pan-kot pan-kot marked this pull request as ready for review May 27, 2026 14:24
@pan-kot pan-kot requested a review from a team as a code owner May 27, 2026 14:24
@pan-kot pan-kot requested review from jperals and removed request for a team May 27, 2026 14:24
@pan-kot pan-kot added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit beaa124 May 27, 2026
45 checks passed
@pan-kot pan-kot deleted the refactor-optimise-multi-selectors branch May 27, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants