fix(rbac): add events.k8s.io RBAC marker#72
Merged
Conversation
On-behalf-of: @SAP krzysztof.zagorski@sap.com Signed-off-by: Zaggy21 <k.zaggy@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing RBAC permissions for emitting/patching Kubernetes Events in the events.k8s.io API group, addressing authorization errors observed at runtime.
Changes:
- Add a
//+kubebuilder:rbacmarker forevents.k8s.ioEvents in the CareInstruction controller. - Regenerate
config/rbac/role.yamlto includeevents.k8s.ioin the manager ClusterRole rules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| controller/careinstruction/careinstruction_controller.go | Adds the events.k8s.io RBAC marker for Events. |
| config/rbac/role.yaml | Regenerated ClusterRole rules to include events.k8s.io Events permissions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
uwe-mayer
previously approved these changes
Jul 8, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Krzysztof Zagorski <k.zaggy@gmail.com>
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
k-fabryczny
self-requested a review
July 9, 2026 08:26
k-fabryczny
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
events.k8s.ioRBAC marker and regeneratedrole.yaml.This fix is done because there appeared logs like:
User \"system:serviceaccount:greenhouse:shoot-grafter\" cannot patch resource \"events\" in API group \"events.k8s.io\".