Fix SCM-Manager URL resolution for tenant and central providers#516
Open
avetgit wants to merge 2 commits into
Open
Fix SCM-Manager URL resolution for tenant and central providers#516avetgit wants to merge 2 commits into
avetgit wants to merge 2 commits into
Conversation
Resolve SCM-Manager service names and namespaces using a provider-specific service prefix instead of the tenant application's global name prefix. Previously, the SCM-Manager URL resolver always used `config.application.namePrefix` when building internal service URLs. In dedicated multi-tenant setups this caused the central SCM-Manager provider to be resolved with the tenant prefix, producing URLs such as `t3-scmm.t3-scm-manager.svc.cluster.local` instead of the central `scmm.scm-manager.svc.cluster.local`. This broke tenant bootstrap generation because central Argo CD tried to load the tenant cluster-resources repository from the tenant SCM-Manager instead of the central SCM-Manager. Tenant SCM providers now receive the tenant service prefix, while central SCM providers are resolved independently. This keeps tenant SCM URLs prefixed and central SCM URLs stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve SCM-Manager service names and namespaces using a provider-specific service prefix instead of the tenant application's global name prefix.
Previously, the SCM-Manager URL resolver always used
config.application.namePrefixwhen building internal service URLs. In dedicated multi-tenant setups this caused the central SCM-Manager provider to be resolved with the tenant prefix, producing URLs such ast3-scmm.t3-scm-manager.svc.cluster.localinstead of the centralscmm.scm-manager.svc.cluster.local.This broke tenant bootstrap generation because central Argo CD tried to load the tenant cluster-resources repository from the tenant SCM-Manager instead of the central SCM-Manager.
Tenant SCM providers now receive the tenant service prefix, while central SCM providers are resolved independently. This keeps tenant SCM URLs prefixed and central SCM URLs stable.