fix: restore WAL from replica source during designated primary promotion#966
Merged
mnencia merged 2 commits intoJun 18, 2026
Merged
Conversation
dosubot
Bot
added
size:S
armru
approved these changes
Jun 18, 2026
mnencia
force-pushed
the
restore-wal-replica-promotion
branch
from
fd6b393 to
ae60cb1
Compare
During a replica cluster failover, the designated primary could incorrectly attempt to restore WALs from its own object store instead of the replica source, causing recovery to fail. This happened because the previous logic relied on IsReplica() returning true, but that flag can already be false while PostgreSQL is still in recovery and needs WALs from the source cluster. Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Extract the restore_command object-store selection out of Restore into a pure resolveRestoreObjectStore helper and add table-driven coverage for the routing decision, including the designated-primary promotion case (both switchover and failover) that previously had no regression test. The refactor is behavior-preserving; it also makes the gocognit suppression on Restore unnecessary, so it is dropped. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
force-pushed
the
restore-wal-replica-promotion
branch
from
ae60cb1 to
c62a20f
Compare
mnencia
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a replica cluster failover, the designated primary could incorrectly attempt to restore WALs from its own object store instead of the replica source, causing recovery to fail. This happened because the previous logic relied on IsReplica() returning true, but that flag can already be false while PostgreSQL is still in recovery and needs WALs from the source cluster.