fix(wrangler): hide multi-env warning when env is set via CLOUDFLARE_ENV

[greyvugrin]

Changes:

• Updated tests for wrangler commands to account for this use case (env specified through CLOUDFLARE_ENV)
• Added fix that leverages computed targetEnvironment
• Updated warning message to mention CLOUDFLARE_ENV
• Updated tests to use a helper for the warning message text to check against

Example of failures prior to adjusting the source code:

---

• Tests
  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: this updates behavior to match existing docs

Photo by Sierra NiCole Narvaeth on Unsplash

[changeset-bot]

🦋 Changeset detected

Latest commit: 4dd4a0b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[workers-devprod]

Codeowners approval required for this PR:

• @cloudflare/wrangler

Show detailed file reviewers

• .changeset/mighty-planes-give.md: [@cloudflare/wrangler]
• packages/workers-utils/src/config/config-helpers.ts: [@cloudflare/wrangler]
• packages/workers-utils/src/index.ts: [@cloudflare/wrangler]
• packages/wrangler/src/tests/deploy/environments.test.ts: [@cloudflare/wrangler]
• packages/wrangler/src/tests/secret.test.ts: [@cloudflare/wrangler]
• packages/wrangler/src/tests/versions/secrets/bulk.test.ts: [@cloudflare/wrangler]
• packages/wrangler/src/tests/versions/secrets/delete.test.ts: [@cloudflare/wrangler]
• packages/wrangler/src/tests/versions/secrets/put.test.ts: [@cloudflare/wrangler]
• packages/wrangler/src/tests/versions/versions.deploy.test.ts: [@cloudflare/wrangler]
• packages/wrangler/src/tests/versions/versions.upload.test.ts: [@cloudflare/wrangler]
• packages/wrangler/src/core/register-yargs-command.ts: [@cloudflare/wrangler]

[petebacondarwin]

Is this quite right?

If we are processing a redirected config, then this value is the one environment used when generating the redirected config. It's purpose is so that we can ensure that any --env or CLOUDFLARE_ENV (i.e. the current selected environment) matches the original target.

So this code might work where there is no redirected config, which I think is the case for all the tests above. But will fail otherwise...

[greyvugrin]

Ah gotcha, yep I see the issue. Added a test to cover that case (it failed) and then updated the code to fix it.
Added a helper to detect if it's a redirected config to not duplicate the logic there.

Also, added tests for the expected --env="" behavior to ensure that's preserved moving forward.

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13827

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13827

miniflare

npm i https://pkg.pr.new/miniflare@13827

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13827

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13827

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13827

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13827

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13827

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13827

wrangler

npm i https://pkg.pr.new/wrangler@13827

commit: 4dd4a0b