[wrangler] Disable Sentry error reporting by default#13815
Draft
[wrangler] Disable Sentry error reporting by default#13815
Conversation
The current Sentry consent prompt fires on every error and produces too many false-positive reports. Default WRANGLER_SEND_ERROR_REPORTS to false so we neither prompt nor send by default. Users can still opt in by setting WRANGLER_SEND_ERROR_REPORTS=true.
🦋 Changeset detectedLatest commit: d33b3af The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
LGTM |
Contributor
Changeset ReviewFile:
|
| Check | Status | Notes |
|---|---|---|
| Version Type | ✅ | patch is appropriate for this behavioral change (reducing friction by disabling prompts) |
| Changelog Quality | ✅ | Clear title, explains the change and reasoning (false-positive reports), includes opt-in instructions |
| Markdown Headers | ✅ | No h1/h2/h3 headers |
| Analytics | ✅ | This change reduces analytics collection, so the minor version rule for adding analytics does not apply |
| Dependabot | ✅ | Not a dependency update |
| Experimental Features | ✅ | Not an experimental feature change |
✅ All changesets look good
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
- Drop the prompt output from the non-interactive 'should not hit sentry after error' snapshot (the consent prompt no longer fires by default). - Remove the two tests that exercised the consent prompt path: that path is no longer reachable because WRANGLER_SEND_ERROR_REPORTS now defaults to false rather than undefined. The remaining tests already cover both the explicit-true and explicit-false env var cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change...
WRANGLER_SEND_ERROR_REPORTSnow defaults tofalseinstead ofundefined. Previously, when the env var was unset, Wrangler would prompt the user on every error asking whether to report to Sentry. The prompt produces too many false-positive reports, so we now default to off. Users can still opt in by settingWRANGLER_SEND_ERROR_REPORTS=true.The behaviour of the Sentry code path itself is unchanged — the only change is the default value of the env var. The existing prompt code in `captureGlobalException` is now dead in practice (the env var is always defined), but is left in place for the moment.
This will require updating `packages/wrangler/src/tests/sentry.test.ts` to match the new behaviour (a few prompt-driven tests need to switch to the env var, or be removed). I haven't done that yet — happy to do it in this PR or a follow-up depending on review preference.