Skip to content

fix: use explicit context providers#554

Merged
mattrothenberg merged 1 commit into
mainfrom
matt/kumo-main-react18-context-provider
May 29, 2026
Merged

fix: use explicit context providers#554
mattrothenberg merged 1 commit into
mainfrom
matt/kumo-main-react18-context-provider

Conversation

@mattrothenberg
Copy link
Copy Markdown
Collaborator

Summary

Fix React 18 compatibility for Combobox and Autocomplete by using the explicit context provider API instead of React 19 provider shorthand.

React 19 allows rendering context objects directly as providers:

<SomeContext value={value}>

React 18 treats that as a context consumer and expects function children, which crashes for normal JSX children. <SomeContext.Provider value={...}> is supported in both React 18 and React 19.

This should release as a patch (2.4.1) via the included changeset.

Testing

  • pnpm --filter @cloudflare/kumo typecheck

  • pnpm --filter @cloudflare/kumo test

  • Reviews

  • bonk has reviewed the change

  • automated review not possible because: tactical React compatibility fix with direct source verification and package tests

  • Tests

  • Tests included/updated

  • Automated tests not possible - manual testing has been completed as follows: n/a

  • Additional testing not necessary because: n/a

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 29, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@554

commit: 03ce435

@github-actions
Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: 77eff0f

@mattrothenberg
Copy link
Copy Markdown
Collaborator Author

/bonk review and approve

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression Report — 11 changed, 8 unchanged

11 screenshot(s) with visual changes:

Autocomplete / Autocomplete With Field

244 px (0.21%) changed

Before After Diff
Before After Diff

Autocomplete / Autocomplete Sizes

6,264 px (3.37%) changed

Before After Diff
Before After Diff

Combobox / Combobox

782 px (0.77%) changed

Before After Diff
Before After Diff

Combobox / Combobox Sizes

1,592 px (1.47%) changed

Before After Diff
Before After Diff

Combobox / Combobox Sizes Searchable Inside

972 px (0.96%) changed

Before After Diff
Before After Diff

Combobox / Combobox Searchable Inside

561 px (0.55%) changed

Before After Diff
Before After Diff

Combobox / Combobox Searchable Select

625 px (0.62%) changed

Before After Diff
Before After Diff

Combobox / Combobox Grouped

663 px (0.65%) changed

Before After Diff
Before After Diff

Combobox / Combobox Multiple

1,072 px (1.06%) changed

Before After Diff
Before After Diff

Combobox / Combobox With Field

1,498 px (1.26%) changed

Before After Diff
Before After Diff

Combobox / Combobox Error

2,101 px (1.79%) changed

Before After Diff
Before After Diff
8 screenshot(s) unchanged
  • Autocomplete / Autocomplete
  • Autocomplete / Autocomplete Controlled
  • Autocomplete / Autocomplete Error
  • Autocomplete / Autocomplete Grouped
  • Combobox / Combobox Custom Trigger
  • Combobox / Combobox Disabled
  • Combobox / Combobox Disabled Items
  • Combobox (Open)

Generated by Kumo Visual Regression

@mattrothenberg mattrothenberg merged commit 2daa237 into main May 29, 2026
16 checks passed
@mattrothenberg mattrothenberg deleted the matt/kumo-main-react18-context-provider branch May 29, 2026 18:27
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 29, 2026

fatal: couldn't find remote ref matt/kumo-main-react18-context-provider

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 29, 2026

@mattrothenberg Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants