fix: use explicit context providers#554
Merged
Merged
Conversation
commit: |
Contributor
Docs PreviewCommit: |
Collaborator
Author
|
/bonk review and approve |
Contributor
stritt
approved these changes
May 29, 2026
Contributor
|
fatal: couldn't find remote ref matt/kumo-main-react18-context-provider |
Contributor
|
@mattrothenberg Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

































Summary
Fix React 18 compatibility for Combobox and Autocomplete by using the explicit context provider API instead of React 19 provider shorthand.
React 19 allows rendering context objects directly as providers:
React 18 treats that as a context consumer and expects function children, which crashes for normal JSX children.
<SomeContext.Provider value={...}>is supported in both React 18 and React 19.This should release as a patch (2.4.1) via the included changeset.
Testing
pnpm --filter @cloudflare/kumo typecheckpnpm --filter @cloudflare/kumo testReviews
bonk has reviewed the change
automated review not possible because: tactical React compatibility fix with direct source verification and package tests
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows: n/a
Additional testing not necessary because: n/a