Repository navigation
chore: update Forge and OpenAPI to 63e1320f37aa - #220
petebacondarwin wants to merge 1 commit into
Conversation
commit: |
|
| mean | stddev | min | max | |
|---|---|---|---|---|
| PR | 252.9 ms | 3.6 ms | 247.9 ms | 260.4 ms |
| base | 250.1 ms | 2.4 ms | 244.7 ms | 253.1 ms |
Δ (PR vs base): ↑ +2.8 ms (+1.1%)
Measured with hyperfine on ubuntu-latest (3 warmup runs, 20 timed runs). CI numbers carry ±a few ms of runner jitter; treat small deltas as noise.
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
| choices: ["local", "cloudflare"], | ||
| default: "local", | ||
| }) | ||
| .option("name", { |
There was a problem hiding this comment.
Warning: This regeneration drops the public --config-src flag and its config_src body mapping, even though CreateTunnelsRequest still supports that field. Existing --config-src cloudflare invocations are now rejected by strict yargs, leaving only the raw JSON escape hatch for remotely managed tunnels. Restore the field in the Forge overlay and regenerate.
| .option("name", { | |
| .option("config-src", { | |
| type: "string", | |
| choices: ["local", "cloudflare"], | |
| default: "local", | |
| }) | |
| .option("name", { |
|
🤖 I've done a thorough review of your PR. Updates Forge/OpenAPI artifacts and expands the generated command and SDK surface.
|
b6ff852 to
b2ff88a
Compare
| "When true, executes the query without persisting the results. Useful for validation or previewing.", | ||
| default: false, | ||
| }) | ||
| .option("granularity", { |
There was a problem hiding this comment.
Warning: This regeneration removes --dry from both Observability query commands, so cf observability telemetry query --dry ... and cf observability shared-queries create --dry ... now fail strict yargs. Their regenerated SDK request types still expose dry?: boolean as the non-persisting validation/preview mode. Restore the field mapping in the Observability Forge overlay and regenerate; do not patch these generated files directly.
| .command($get) | ||
| .command($post) | ||
| .command($introspection) | ||
| .command($datasets) |
There was a problem hiding this comment.
Warning: Moving the POST command here leaves the existing GET /analytics/sql operation unregistered: analytics/sql/client/Client.ts still exposes client.analytics.sql.get(...), but cf analytics sql get has been removed and neither sql query nor sql datasets issues GET. Preserve a generated leaf/alias for that operation (and retain aliases for the moved POST and datasets commands) in Forge so existing scripts do not lose the GET query mode.
| .command($listmarkdownsupportedformats) | ||
| .command($run) | ||
| .command($tomarkdown) | ||
| .command($websearch) |
There was a problem hiding this comment.
Warning: cf ai-gateway web-search was a published command in the prior metadata and is now rejected because the same operation is only registered at cf ai websearch. Add the old group/method projection through x-forge-aliases in the Forge overlay before regenerating, rather than silently breaking existing automation.
| builder: (yargs) => { | ||
| return yargs | ||
| .command($enableddomains) | ||
| .command($operator) |
There was a problem hiding this comment.
Warning: These are the same Pay Per Use operations previously registered under cf pay-per-crawl pay-per-use ..., but that parent no longer registers them. Strict yargs now rejects every established path in that subtree. Keep the prior group projections as Forge aliases while exposing this corrected top-level hierarchy.
|
|
||
| builder: (yargs) => { | ||
| return yargs | ||
| .command($auditsshsettings) |
There was a problem hiding this comment.
Warning: Moving Audit SSH Settings here removes cf zero-trust gateway audit-ssh-settings {get,rotate-seed,update}. The unchanged E2E catalogue still invokes all three removed paths at packages/cli/e2e/zero-trust.json:5451, :6375, and :6816, so those scenarios now fail before reaching the API. Retain the Gateway paths as Forge aliases (or update the catalogue if this is an intentional breaking change).
|
🤖 I've done a thorough review of your PR. Updates Forge/OpenAPI artifacts and regenerates the CLI and SDK surface.
|
b2ff88a to
298a4f8
Compare
| const sdkVersionPath = join(sdkDir, "openapi-version"); | ||
| // The SDK is committed. Bump this SHA to regenerate it from a new release. | ||
| const FORGE_OPENAPI_VERSION = "10cdded1d9e93c9b055e27cac83b397b2bd7f0c6"; | ||
| const FORGE_OPENAPI_VERSION = "63e1320f37aa10721d912f0876d02bc740d05331"; |
There was a problem hiding this comment.
Warning: This advances the generator pin but does not update the tracked artifacts it owns. packages/cli/src/sdk/openapi-version still records 10cdded1d9e93c9b055e27cac83b397b2bd7f0c6, and the pull request contains no src/sdk/ or src/commands/_generated/ changes. As a result, a fresh generation rewrites the committed SDK and command surface, while source consumers keep using the old API until then. Run pnpm generate with this pin and commit the resulting SDK, generated command tree, metadata, and updated version marker.
|
🤖 I've done a thorough review of your PR. Updates the Forge transformer and pins a newer Forge OpenAPI release.
|
ant-release-bot
changed the title
298a4f8 to
33cc1bf
Compare
|
No new concerns since the last review |
1 participant
Updates cf to
openapi@63e1320f37aa10721d912f0876d02bc740d05331.63e1320f37aa10721d912f0876d02bc740d0533186cb1ef3047abc7441d96c894e8cd35e826fa8e5from the matching release tagUpdater validation failed at
pnpm generate. The PR remains open so its checks can report the failure and the update can be fixed here. See the updater run.This PR is maintained automatically by the Update Forge workflow.