fix(mcp): handle cold wake in handleMcpMessage RPC entry point#1286
Merged
threepointone merged 1 commit intomainfrom Apr 10, 2026
Merged
fix(mcp): handle cold wake in handleMcpMessage RPC entry point#1286threepointone merged 1 commit intomainfrom
threepointone merged 1 commit intomainfrom
Conversation
Call __unsafe_ensureInitialized() at the start of McpAgent.handleMcpMessage to hydrate this.name from storage and run onStart before processing native DO RPC messages. This prevents crashes like "Attempting to read .name before it was set" when a Durable Object wakes from hibernation via RPC. Adds unit tests that seed __ps_name and exercise handleMcpMessage for cold-wake initialization and subsequent tool calls, and includes a changeset entry describing the fix.
🦋 Changeset detectedLatest commit: 3b632d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1282.
McpAgent.handleMcpMessageis a native DO RPC method that bypasses PartyServer'sfetch/alarm/webSocketentry points where#ensureInitialized()normally runs. When the MCP server DO wakes from hibernation via this path,this.namewas never hydrated from storage, causing a crash.handleMcpMessagewith a singleawait this.__unsafe_ensureInitialized()call, matching the pattern used by_workflow_handleCallback,_workflow_broadcast,_workflow_updateState, andalarm().onStart(missed Agent-level MCP client restore, workflow checks, etc.).Test plan
__ps_namedirectly in storage (bypassingsetName/onStart), then callinghandleMcpMessageas the first entry pointMade with Cursor