Fix 7 broken Day 1-7 links on First 7 Days index page#101
Open
melvincarvalho wants to merge 1 commit into
Open
Fix 7 broken Day 1-7 links on First 7 Days index page#101melvincarvalho wants to merge 1 commit into
melvincarvalho wants to merge 1 commit into
Conversation
Bare links like (day-1-make-it-yours) resolved against the page URL /guides/first-7-days, producing nonexistent /guides/day-X URLs. Link to the .md files instead so the docs plugin resolves them against the filesystem. Verified: build no longer reports broken links and the generated hrefs point to /guides/first-7-days/day-X. Fixes #83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
Bare links like
(day-1-make-it-yours)on the First 7 Days index resolved against the page URL/guides/first-7-days, producing nonexistent/guides/day-XURLs — all 7 day links on the live page 404.Changed the table links to file-relative
.mdform (./day-1-make-it-yours.md) so the docs plugin resolves them against the filesystem regardless of slug.Verification:
npm run buildno longer prints the broken-links warning block/guides/first-7-days/day-XNote: a
./day-Xprefix without the.mdextension was tried first and still resolves against the URL path — the.mdextension is what makes it filesystem-resolved.