Skip to content

Bump supported PostgreSQL minors - #244

Merged
ibrahim halatci (ihalatci) merged 2 commits into
masterfrom
ihalatci-bump-pg17-pg18-images
Sep 1, 2026
Merged

Bump supported PostgreSQL minors#244
ibrahim halatci (ihalatci) merged 2 commits into
masterfrom
ihalatci-bump-pg17-pg18-images

Conversation

@ihalatci

Copy link
Copy Markdown
Contributor

Stacked on #240.

Use PostgreSQL 17.11 and 18.6 for test image builds after PG16 support is removed.

Use PostgreSQL 17.11 and 18.6 for the test image build.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f0b20afc-67e7-45fd-890a-ca66519f0c45
Retain the newly added PG19 test image while keeping this PR limited to the PG17 and PG18 minor bumps.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f0b20afc-67e7-45fd-890a-ca66519f0c45
Base automatically changed from ihalatci-drop-pg16-images to master September 1, 2026 09:47
@ihalatci
ibrahim halatci (ihalatci) merged commit dba9cbb into master Sep 1, 2026
16 checks passed
ibrahim halatci (ihalatci) added a commit to citusdata/citus that referenced this pull request Sep 2, 2026
DESCRIPTION: Quote EXTRACT fields and support latest PostgreSQL minors

Fixes #8803.

## Changes

- quote EXTRACT field identifiers in the copied PG17 and PG18 ruleutils
implementations; `ruleutils_19.c` already carries the equivalent fix
from #8753;
- run one discriminating, repeat-safe regression across supported
PostgreSQL versions from the N-1-excluded create-Citus schedule; PG19
retains its dedicated #8753 coverage;
- bump CI coverage from 17.10 / 18.4 to 17.11 / 18.6;
- forward-port the already-landed release-14 fallout for the new
PostgreSQL security minors, including `output_plugin_libraries` handling
and modern psql COPY behavior;
- add PG18 to the `test-citus-upgrade` matrix.

### PG18 citus upgrade coverage

`citusupgradetester` is built and published for PG18
(`CITUS_UPGRADE_VERSIONS_18=v14.2.0`), but the matrix listed only PG17,
so that image was built and never exercised. This adds it, matching the
convention on `release-14.0`, which lists every supported major except
the newest.

PG19 stays out deliberately. The image compiles released Citus from
source, and no released Citus supports PG19 yet, which is why
the-process filters it out of `CITUS_UPGRADE_PG_VERSIONS`. PG19 upgrade
paths are still covered by `test-pg-upgrade`, whose matrix already
includes 17→18, 18→19, and 17→19.

## Cross-repo dependency

The test images are built by
[the-process#244](citusdata/the-process#244),
stacked above
[the-process#240](citusdata/the-process#240).
Both have merged, along with #8757 and #8764, so this PR is last in that
sequence and now pins the released `-vdba9cbb` suffix.

## Validation

- `-Werror` builds: PostgreSQL 17.11, 18.6, and 19beta3
- shared `extract_deparse`: 8/8 repetitions on each of PostgreSQL 17.11,
18.6, and 19beta3
- focused PG17, PG18, and PG19 version regressions
- focused `split_output_plugin_denied` regression on PG18.6
- `citus_indent --check`
- SQL snapshot and test-schedule checks
- `pg_regress_multi.pl` syntax check
- all 13 image tags referenced by the workflow resolved against GHCR at
the `-vdba9cbb` suffix before pinning

## Known limitation carried over from the release branches

The `output_plugin_libraries` preflight splits the GUC on commas, so a
plugin name containing a comma inside a quoted element (`"a,b"`) is not
parsed the way PostgreSQL's `SplitGUCList` would parse it. This is
unreachable for the name `citus` and matches what already shipped on
release-14.0, release-13.2, and release-12.1.

---------

Co-authored-by: Ibrahim Halatci <ihalatci@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ihalatci <10450368+ihalatci@users.noreply.github.com>
Co-authored-by: ihalatci <ihalatci@users.noreply.github.com>
Copilot-Session: 7c6370b2-06fd-4491-bf92-ecb811d34518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants