Align nightly cassert with main: 17.11 / 18.6 / 19beta3, drop PG16 - #8822
Merged
Merged
Conversation
Bump 17.9->17.11 and 18.3->18.6 to match build_and_test.yml after #8804. PG16 (16.13) intentionally unchanged (main sets no 16 minor). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8822 +/- ##
==========================================
- Coverage 88.73% 88.72% -0.01%
==========================================
Files 289 289
Lines 65013 65013
Branches 8204 8204
==========================================
- Hits 57687 57686 -1
+ Misses 4957 4956 -1
- Partials 2369 2371 +2 🚀 New features to boost your workflow:
|
ibrahim halatci (ihalatci)
marked this pull request as ready for review
September 3, 2026 09:53
Onur Tirtir (onurctirtir)
approved these changes
Sep 8, 2026
Citus main no longer compiles against PostgreSQL 16 -- configure aborts with "Citus is not compatible with the detected PostgreSQL version 16". Every PG16 job in the nightly is therefore guaranteed to fail: run 34182646836 (2026-09-08) had all 14 PG16 jobs red, including PG16-PG17 pg-upgrade. Remove PG16 from all three version lists so the nightly reports real signal instead of a permanently red major: - pg_versions -> 17, 18 - pg_upgrade_pairs -> 17 -> 18 only - citus_upgrade_pg -> 17 only The 17.11 / 18.6 minor alignment from this PR is unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ed7b58a-0ba9-4f47-a1de-3ee665bae7f2
The params job is meant to be a mirror of build_and_test.yml. main now
pins 17.11 / 18.6 / 19beta3 and has no pg16_version at all, so the
nightly was stale in both directions: it carried PG16, which no longer
compiles, and lacked PG19, which main tests.
Bring it back in line with main:
- pg_versions -> 17.11, 18.6, 19beta3
- pg_upgrade_pairs -> 17->18, 18->19, 17->19 (main's three pairs)
- citus_upgrade_pg -> 17.11, 18.6 (main covers 17 and 18; PG19 is
excluded there because old Citus versions do
not run on PG19)
setup_cassert_pg builds PG from source via pgenv and documents beta
versions as supported; the 19beta3 source tarball is published, so the
build is viable.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 1ed7b58a-0ba9-4f47-a1de-3ee665bae7f2
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Realigns
.github/workflows/nightly_cassert.ymlwithmain. Itsparamsjob is meant to be a mirror ofbuild_and_test.yml, but it had drifted in both directions:mainno longer compiles against, andmaindoes test.main's params job currently pins17.11/18.6/19beta3and declares nopg16_versionat all.Changes
pg_versionspg_upgrade_pairscitus_upgrade_pgPlus the file header comment, which advertised
PG 16/17/18and referenced apg19-supportbranch that no longer exists (PG19 landed inmain).citus_old_versionis untouched.Why PG16 comes out
Citus
mainno longer compiles against PostgreSQL 16 —configureaborts with:Every PG16 job was therefore guaranteed to fail regardless of minor. In run 34182646836 (2026-09-08), all 14 PG16 jobs were red:
That is categorically different from a normal cassert failure: it is a build that cannot start, so it drowns out the assert signal this nightly exists to surface.
Why PG19 goes in
mainalready runs PG19 (19beta3), so the nightly should too. Unlike PG16, PG19 does build, so any redness it produces is real assert signal — exactly what this workflow is for, per its own header note that runs are expected to be red as pre-existing asserts surface.citus_upgrade_pgdeliberately stays at 17 + 18, mirroringmain'stest-citus-upgradematrix: the older Citus versions used by that suite do not run on PG19.Verification
The three
paramsoutputs are JSON-in-YAML strings, so they were checked by parsing rather than by eye. A script YAML-loads this workflow and fetchesbuild_and_test.ymlfrommain, then asserts the nightly mirrors it:pg*_versionset exactly (17, 18, 19), and everyfullequals main'spg_upgrade_pairsequals main'stest-pg-upgradeinclude set exactly (17→18, 18→19, 17→19), with eachold_full/new_fullresolved from maincitus_upgrade_pgmajors equal main'stest-citus-upgradematrix (17, 18)16/16.13token remains anywhere in the file, and no stalepg19-supportreferenceResult:
MIRRORS MAIN EXACTLY - ALL ASSERTIONS PASSED.The PG builds are from source via pgenv (
setup_cassert_pg), whose input is documented as accepting betas (e.g. 17.10 / 18.4 / 19beta1). The19beta3source tarball is published (postgresql-19beta3.tar.bz2, HTTP 200), so the build is viable.Notes
Companion to citus#8816 (
nightly_arm64.yml). If that workflow has the same PG16/PG19 drift, it is best fixed there.Refs citus#8804.