Skip to content

fix: evlog bundling#360

Merged
calvinbrewer merged 1 commit intomainfrom
evlog-bundling
Apr 24, 2026
Merged

fix: evlog bundling#360
calvinbrewer merged 1 commit intomainfrom
evlog-bundling

Conversation

@calvinbrewer
Copy link
Copy Markdown
Contributor

@calvinbrewer calvinbrewer commented Apr 24, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Resolved an export error that prevented CommonJS consumers from importing and using the package properly in their applications. Dependencies lacking native CommonJS export support are now bundled directly into the compiled package output at build time, completely eliminating runtime module resolution errors and ensuring seamless compatibility for all users.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 24, 2026

🦋 Changeset detected

Latest commit: 510c485

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cipherstash/stack Patch
@cipherstash/basic-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e66c60a3-ff78-43cd-a359-c666d894c0cd

📥 Commits

Reviewing files that changed from the base of the PR and between ccbe4f4 and 510c485.

📒 Files selected for processing (2)
  • .changeset/bundle-evlog-cjs.md
  • packages/stack/tsup.config.ts

📝 Walkthrough

Walkthrough

The changes update the build configuration for @cipherstash/stack to bundle the pure ESM dependency evlog into CommonJS output at build time, preventing runtime resolution errors when CJS consumers attempt to import it.

Changes

Cohort / File(s) Summary
Bundling Configuration
packages/stack/tsup.config.ts
Updated tsup configuration to exclude evlog from the external dependencies list, ensuring it gets bundled into the output instead of remaining external.
Changeset Documentation
.changeset/bundle-evlog-cjs.md
Documented patch for @cipherstash/stack explaining that evlog is now inlined during bundling to avoid ERR_PACKAGE_PATH_NOT_EXPORTED errors for CJS consumers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A hop and a bundle, evlog takes flight,
No more external calls in the CJS night,
Bundled and nested, all cozy and tight,
The CommonJS path is now shining bright! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'fix: evlog bundling' directly and clearly describes the main change: fixing the bundling of the evlog package to resolve CJS import errors.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch evlog-bundling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@calvinbrewer calvinbrewer merged commit dc22479 into main Apr 24, 2026
6 checks passed
@calvinbrewer calvinbrewer deleted the evlog-bundling branch April 24, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant