Change Emojis & Stickers Pack selector button to dropdown#2733
Open
smokku wants to merge 1 commit intocinnyapp:devfrom
Open
Change Emojis & Stickers Pack selector button to dropdown#2733smokku wants to merge 1 commit intocinnyapp:devfrom
smokku wants to merge 1 commit intocinnyapp:devfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Pull request overview
Updates the Emojis & Stickers “Global Packs” UI to make the pack selector read more clearly as a dropdown and to make the “Save” affordance more visually prominent when selections are made.
Changes:
- Replaces the selector header “Save/Close” action from a
Chipto aButton, with styling that becomes solid “Success” when there are selections. - Adds a down-chevron icon to the “Select Pack” trigger button to match other dropdown triggers.
Author
|
I have read the CLA Document and I hereby sign the CLA |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces two changes resolving confusion I had when dealing with Emojis & Stickers Pack selector.
1. Changes the button to show down chevron like other dropdowns do.
Before change:
After change:
2. Changes the "Save" button to be a Button component instead of Chip component.
When I initially tried to use this dropdown, I've selected the packs I wanted and did not notice the chip in top right corner changed to green "Save".
I've closed the dropdown by clicking outside and got confused that nothing happened.
A large, solid green "Save" button appearing should help get the user focus to it and suggest saving instead of just closing the dropdown.
Before change:
After change: