Skip to content

docs: minor documentation fixes#1223

Merged
chimurai merged 1 commit intomasterfrom
minor-doc-fixes
May 3, 2026
Merged

docs: minor documentation fixes#1223
chimurai merged 1 commit intomasterfrom
minor-doc-fixes

Conversation

@chimurai
Copy link
Copy Markdown
Owner

@chimurai chimurai commented May 3, 2026

Summary by CodeRabbit

  • Documentation

    • Updated migration guidance references in changelog for v3.0.0 migration path
    • Improved documentation links throughout README and recipe guides
    • Enhanced proxy configuration example documentation with updated usage patterns
    • Improved JSDoc documentation and formatting for middleware functions and plugins
  • Bug Fixes

    • Corrected event handler configuration example syntax

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d9b20e26-ca70-49c8-b14e-39ddcd06db22

📥 Commits

Reviewing files that changed from the base of the PR and between c03926d and d5ff0ab.

📒 Files selected for processing (6)
  • CHANGELOG.md
  • README.md
  • recipes/modify-post.md
  • recipes/proxy-events.md
  • src/factory-hono.ts
  • src/plugins/default/debug-proxy-errors-plugin.ts

📝 Walkthrough

Walkthrough

This pull request updates documentation and recipe examples across the project. Changes include correcting migration guide references in the changelog, fixing recipe code examples to use proper object syntax and inline configurations, and enhancing JSDoc comments for clarity. No runtime functionality is altered.

Changes

Documentation and Examples Update

Layer / File(s) Summary
Changelog Corrections
CHANGELOG.md
Updated v3.0.0 migration reference from MIGRATION.md to MIGRATION_V3.md; corrected historical release header from v1.0.6 to v1.0.5.
Documentation Links
README.md
Updated interception recipes link from response-interceptor.md#readme to response-interceptor.md.
Recipe Examples
recipes/modify-post.md, recipes/proxy-events.md
Refactored proxy configuration example to use inline pathFilter within proxy_options; corrected event handler syntax from invalid object form to proper mapping ({ error: onError }).
Source Code Comments
src/factory-hono.ts, src/plugins/default/debug-proxy-errors-plugin.ts
Fixed JSDoc formatting in createHonoProxyMiddleware (added closing code-fence); expanded debugProxyErrorsPlugin documentation to clarify http-proxy error handling and subscription recommendations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • PR #1222: Modifies JSDoc in src/plugins/default/debug-proxy-errors-plugin.ts with related changes to proxy error event documentation.
  • PR #1201: Updates src/factory-hono.ts and createHonoProxyMiddleware with changes to generics and type bindings.

Poem

🐰 A bunny hops through docs with care,
Fixing links and examples fair,
Code fences sealed with proper grace,
Migration guides find their true place!
Errors now dance in syntax right,
All is clear, all is bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs: minor documentation fixes' accurately summarizes the main change: documentation updates across multiple files including changelog corrections, link updates, code examples, and JSDoc improvements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch minor-doc-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 3, 2026

npm i https://pkg.pr.new/http-proxy-middleware@1223

commit: d5ff0ab

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 94.07%. remained the same — minor-doc-fixes into master

@chimurai chimurai merged commit 9a1cdb5 into master May 3, 2026
24 checks passed
@chimurai chimurai deleted the minor-doc-fixes branch May 3, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants