Skip to content

Update the Tidelift banner with a working logo#816

Open
julianz- wants to merge 1 commit intocherrypy:mainfrom
julianz-:fix-tidelift-logo
Open

Update the Tidelift banner with a working logo#816
julianz- wants to merge 1 commit intocherrypy:mainfrom
julianz-:fix-tidelift-logo

Conversation

@julianz-
Copy link
Member

@julianz- julianz- commented Feb 25, 2026

What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • 📋 docs update
  • 📋 tests/coverage improvement
  • 📋 refactoring
  • 💥 other

📋 What is the related issue number (starting with #)
#812

Resolves #

What is the current behavior? (You can also link to an open issue here)
#812

What is the new behavior (if this is a feature change)?
#812

📋 Other information:

📋 Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.19%. Comparing base (4bb134f) to head (7f0f008).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   78.21%   78.19%   -0.03%     
==========================================
  Files          41       41              
  Lines        4788     4788              
  Branches      547      547              
==========================================
- Hits         3745     3744       -1     
  Misses        905      905              
- Partials      138      139       +1     

@webknjaz
Copy link
Member

  • [ X] 🐞 bug fix

@julianz- ^ when you have a whitespace in there, it doesn't render as a checkbox. Try fixing it in the PR description?

.. _Tidelift Subscription: https://tidelift.com/subscription/pkg/pypi-cheroot?utm_source=pypi-cheroot&utm_medium=referral&utm_campaign=readme

.. |tideliftlogo| image:: https://cdn2.hubspot.net/hubfs/4008838/website/logos/logos_for_download/Tidelift_primary-shorthand-logo.png
.. |tideliftlogo| image:: https://tidelift.com/badges/package/pypi/cheroot
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have a duplicate badge in this place — it's already present at the top of the document.

How about integrating a Sphinx extension following what's done in pypa/setuptools@918a415 instead? We could drop this section from the readme that's rendered on GH but keep it integrated in the Sphinx docs (the directive from jaraco's extension would go into docs/index.rst).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants