Update the Tidelift banner with a working logo#816
Open
julianz- wants to merge 1 commit intocherrypy:mainfrom
Open
Update the Tidelift banner with a working logo#816julianz- wants to merge 1 commit intocherrypy:mainfrom
julianz- wants to merge 1 commit intocherrypy:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 78.21% 78.19% -0.03%
==========================================
Files 41 41
Lines 4788 4788
Branches 547 547
==========================================
- Hits 3745 3744 -1
Misses 905 905
- Partials 138 139 +1 |
Member
@julianz- ^ when you have a whitespace in there, it doesn't render as a checkbox. Try fixing it in the PR description? |
webknjaz
reviewed
Feb 25, 2026
| .. _Tidelift Subscription: https://tidelift.com/subscription/pkg/pypi-cheroot?utm_source=pypi-cheroot&utm_medium=referral&utm_campaign=readme | ||
|
|
||
| .. |tideliftlogo| image:: https://cdn2.hubspot.net/hubfs/4008838/website/logos/logos_for_download/Tidelift_primary-shorthand-logo.png | ||
| .. |tideliftlogo| image:: https://tidelift.com/badges/package/pypi/cheroot |
Member
There was a problem hiding this comment.
I don't think we should have a duplicate badge in this place — it's already present at the top of the document.
How about integrating a Sphinx extension following what's done in pypa/setuptools@918a415 instead? We could drop this section from the readme that's rendered on GH but keep it integrated in the Sphinx docs (the directive from jaraco's extension would go into docs/index.rst).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ What kind of change does this PR introduce?
📋 What is the related issue number (starting with
#)#812
Resolves #
❓ What is the current behavior? (You can also link to an open issue here)
#812
❓ What is the new behavior (if this is a feature change)?
#812
📋 Other information:
📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences