Skip to content

Remove mvbox_move and only_fetch_mvbox#7780

Open
link2xt wants to merge 2 commits intomainfrom
link2xt/remove-mvbox_move
Open

Remove mvbox_move and only_fetch_mvbox#7780
link2xt wants to merge 2 commits intomainfrom
link2xt/remove-mvbox_move

Conversation

@link2xt
Copy link
Collaborator

@link2xt link2xt commented Jan 27, 2026

only_fetch_mvbox option is moved to per-relay configuration parameter imap_folder, similar to IMAP port.

First commit closes #7655

Second commit closes #7648

Options mvbox_move and only_fetch_mvbox are removed.

mvbox_move was deprecated already and there is a device message telling users to disable it.

only_fetch_mvbox is replaced with a per-transport "IMAP folder" option, similar to "IMAP user". Selecting the correct IMAP folder is essentially a part of the login process. By default "INBOX" is selected, but to support existing setups, this can be set to "DeltaChat" or "INBOX.DeltaChat" or similar configuration.

In the core crate, EnteredLoginParam, now has a nested "imap.folder" field of string type, similar to "imap.port" or "imap.user". It is non-optional, but can be an empty string which means user has not entered anything. In this case during configuration "INBOX" folder will be assumed. This is the type stored in the entered_param column of the transports table.

JSON-RPC type EnteredLoginParam, which is a flat dictionary, now includes optional imap_folder value.
If it is not set, watched folder is "INBOX", otherwise the one set here.
It should not be an empty string.

@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch 2 times, most recently from 1047039 to 7123e33 Compare January 27, 2026 02:38
@link2xt link2xt force-pushed the link2xt/qvtsmounuoql branch from abc30a5 to 4b8ede9 Compare January 27, 2026 23:40
@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch 2 times, most recently from a1e3ec1 to 46d07d7 Compare January 27, 2026 23:42
@link2xt link2xt force-pushed the link2xt/qvtsmounuoql branch from 4b8ede9 to 013d4ec Compare January 27, 2026 23:42
@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch from 46d07d7 to 4c7a420 Compare January 28, 2026 02:37
@link2xt link2xt force-pushed the link2xt/qvtsmounuoql branch from 013d4ec to c08c187 Compare January 28, 2026 14:56
@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch from 4c7a420 to 0811892 Compare January 28, 2026 14:56
@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch from 0811892 to ca37715 Compare February 4, 2026 01:19
@link2xt link2xt force-pushed the link2xt/qvtsmounuoql branch from c08c187 to 63aab19 Compare February 4, 2026 01:19
@link2xt link2xt changed the base branch from link2xt/qvtsmounuoql to main February 4, 2026 03:23
@link2xt link2xt changed the base branch from main to link2xt/dont-scan-folders February 4, 2026 03:24
@link2xt link2xt changed the title Remove mvbox_move Remove mvbox_move and only_fetch_mvbox Feb 4, 2026
@link2xt link2xt self-assigned this Feb 4, 2026
@link2xt link2xt force-pushed the link2xt/dont-scan-folders branch from 72c5c1f to 369bd3c Compare February 6, 2026 23:42
@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch 7 times, most recently from 27623d0 to 0855098 Compare February 7, 2026 04:13
Base automatically changed from link2xt/dont-scan-folders to main February 8, 2026 01:57
@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch 3 times, most recently from 6767ea2 to 996e24e Compare February 10, 2026 11:24
@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch 7 times, most recently from 7da6f4a to 39da128 Compare February 17, 2026 20:38
@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch 3 times, most recently from 669010f to 6b2a72c Compare February 23, 2026 01:04
@link2xt link2xt marked this pull request as ready for review February 23, 2026 01:04
@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch from 6b2a72c to 2f4e311 Compare February 23, 2026 01:18
@Hocuri
Copy link
Collaborator

Hocuri commented Feb 23, 2026

Is this ready for review? Because #7655 says "one release after #7654 is merged". #7654 got into v2.36.0, which is only being released now with the current releases, and we may need to do a bugfix release.

@link2xt
Copy link
Collaborator Author

link2xt commented Feb 23, 2026

It is ready for review, but I have not tested a migration yet on my test account that uses "only fetch mvbox" and not going to merge it soon even after review so it does not get into bugfix releases. It bumps dcbackup version because downgrade may result in accidentally reading inbox instead of the other folder, so it is aimed for the next larger release.

Since commit 25750de
released in 2.36.0 we do not move messages to mvbox without explicit
mvbox_move setting, so do not need to watch it as well
as long as other devices are updated to the same change.
@link2xt link2xt force-pushed the link2xt/remove-mvbox_move branch from 2f4e311 to d6dacdc Compare February 25, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tweak should_watch_mvbox to not depend on is_chatmail Remove mvbox_move and only_fetch_mvbox options

2 participants