Open
Conversation
1047039 to
7123e33
Compare
abc30a5 to
4b8ede9
Compare
a1e3ec1 to
46d07d7
Compare
4b8ede9 to
013d4ec
Compare
46d07d7 to
4c7a420
Compare
013d4ec to
c08c187
Compare
4c7a420 to
0811892
Compare
0811892 to
ca37715
Compare
c08c187 to
63aab19
Compare
72c5c1f to
369bd3c
Compare
27623d0 to
0855098
Compare
6767ea2 to
996e24e
Compare
7da6f4a to
39da128
Compare
669010f to
6b2a72c
Compare
6b2a72c to
2f4e311
Compare
Collaborator
Collaborator
Author
|
It is ready for review, but I have not tested a migration yet on my test account that uses "only fetch mvbox" and not going to merge it soon even after review so it does not get into bugfix releases. It bumps dcbackup version because downgrade may result in accidentally reading inbox instead of the other folder, so it is aimed for the next larger release. |
Since commit 25750de released in 2.36.0 we do not move messages to mvbox without explicit mvbox_move setting, so do not need to watch it as well as long as other devices are updated to the same change.
2f4e311 to
d6dacdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only_fetch_mvboxoption is moved to per-relay configuration parameterimap_folder, similar to IMAP port.First commit closes #7655
Second commit closes #7648
Options mvbox_move and only_fetch_mvbox are removed.
mvbox_move was deprecated already and there is a device message telling users to disable it.
only_fetch_mvbox is replaced with a per-transport "IMAP folder" option, similar to "IMAP user". Selecting the correct IMAP folder is essentially a part of the login process. By default "INBOX" is selected, but to support existing setups, this can be set to "DeltaChat" or "INBOX.DeltaChat" or similar configuration.
In the core crate, EnteredLoginParam, now has a nested "imap.folder" field of string type, similar to "imap.port" or "imap.user". It is non-optional, but can be an empty string which means user has not entered anything. In this case during configuration "INBOX" folder will be assumed. This is the type stored in the entered_param column of the transports table.
JSON-RPC type EnteredLoginParam, which is a flat dictionary, now includes optional imap_folder value.
If it is not set, watched folder is "INBOX", otherwise the one set here.
It should not be an empty string.