[ENT-12099] Initial implementation of an experimental feature of policy set analysis#218
Conversation
|
Thanks for submitting a PR! Maybe @craigcomstock can review this? |
craigcomstock
left a comment
There was a problem hiding this comment.
a few questions/comments, all looks good-to-go except maybe moving the release-information checksum into a separate file, that might be a nice change for maintenance purposes.
2c2c407 to
962aee5
Compare
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
…nalyze` Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
|
@jakub-nt Same as in the other PR; please put some examples of you running commands and showing the output here in the PR and/or in the README :) |
craigcomstock
left a comment
There was a problem hiding this comment.
Generally looks great.
nickanderson
left a comment
There was a problem hiding this comment.
@jakub-nt some thoughts from playing with this recently:
- Would be cool to provide an option to show the diff. Would have to have the actual original file to show that …
Files from the version but with modifications:
└── masterfiles/promises.cf
-
Convert to cfbs, interactively
-
Condense these?
Files missing from the version:
└── masterfiles/lib/3.7/paths.cf
Files moved or renamed:
└── ('masterfiles/lib/3.7/paths.cf-moved', [('masterfiles/lib/3.7/paths.cf', ['3.7.5'])])
Move some of the long dense messages with tuples to verbose logging.
|
Ye, the first 2 things Nick mention are separate tasks (diffs and convert). The last 2 things we probably want to fix. @jakub-nt let's do this:
|
…n distribution by default Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
Signed-off-by: jakub-nt <175944085+jakub-nt@users.noreply.github.com>
No description provided.